ci(cppcheck-all): rename to cppcheck-daily and make it run only daily

[kminoda]

Description

Rename cppcheck-all to cppcheck-monitor to make the name self-contained.
I also would like to make it pass always as it may be a noise for developers.

Tests performed

Please check the CI results of this PR (it should pass)

Effects on system behavior

None

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

[xmfcx]

Why did you remove

  - name: Fail the job if Cppcheck failed
        if: steps.cppcheck.outcome == 'failure'
        run: exit 1

Part, I think it's better if it fails on failure.

So we can track where things went wrong.

[kminoda]

@xmfcx Now that this CI is going to be a monitor rather than a check, I think it would be better to make it succeed regardless of the cppcheck results. Also it is obvious that cppcheck still outputs bunch of errors.
We can remove this CI eventually when all the cppcheck errors have been mitigated. (This way we may also be able to know when the CI is failing for some other reason, e.g. errors while installing cppcheck)

But if this may be confusing for other developers, I can leave that part. What do you think?

[xmfcx]

I still think it should fail on failure. It is a daily job anyways. Most people won't even see it so it is ok.

[xmfcx]

@kminoda

Also it is obvious that cppcheck still outputs bunch of errors.

It is not obvious, it will only be known if you click into the individual workflow run logs.

We can remove this CI eventually when all the cppcheck errors have been mitigated. (This way we may also be able to know when the CI is failing for some other reason, e.g. errors while installing cppcheck)

This action can stay to run daily forever. Maybe some files will go past cppcheck somehow, this will warn us in general.

But if this may be confusing for other developers, I can leave that part. What do you think?

It won't be, it is only accessible if someone purposefully goes to https://github.com/autowarefoundation/autoware.universe/actions/workflows/cppcheck-monitor.yaml page. Because it is a scheduled daily job.

And people going to that link wants to know the answer to this question: "since when was this workflow failing?"

If you hide it, then we need to click each workflow run one by one.

[xmfcx]

To be honest, the name cppcheck-all is better, it conveys what it does better. Maybe even cppcheck-daily.

[xmfcx]

Thank you! Let's wait for pre-commit.ci to fix the file ending and we can merge ✅