Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(yabloc): suppress no viable conversion error #7299

Merged

Conversation

KYabuuchi
Copy link
Contributor

@KYabuuchi KYabuuchi commented Jun 6, 2024

Description

I suppressed the warnings reported in #7210
Some other warnings still remain. Only the "no viable conversion error" has been resolved.

To resolve no viable conversion error I made the following change

  • Used static_cast for explicit type conversion
  • Used the direct creation of ColorRGBA with tier4_autoware_utils::createMarkerColor

Tests performed

Confirm that the error has been resolved by comparing the outputs of clang-tidy.

Below, I have provided links to the previous clang-tidy's outputs and those generated by this PR.

Confirmed that yabloc works as conventional in logging_simulator

ros2 launch autoware_launch logging_simulator.launch.xml \
    map_path:=$HOME/Maps/nishishinjuku \
    vehicle_model:=sample_vehicle \
    sensor_model:=awsim_sensor_kit \
    pose_source:=yabloc

Effects on system behavior

This PR does not change the system behavior.

Interface changes

Interface does not change.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

KYabuuchi added 5 commits June 6, 2024 11:57
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
@KYabuuchi KYabuuchi added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 6, 2024
@github-actions github-actions bot added the component:localization Vehicle's position determination in its environment. (auto-assigned) label Jun 6, 2024
@KYabuuchi KYabuuchi marked this pull request as ready for review June 6, 2024 08:09
@SakodaShintaro
Copy link
Contributor

I don't really understand what the change means, but I don't think it's a problem.

Small comments

(1) The CI check "semantic-pull-request" is failing for some reason (is it because there are spaces on both sides of the ":"?)

(2) There is a "()" in the "Tests performed" section in PR description.

image

@KYabuuchi KYabuuchi changed the title fix(yabloc) : suppress no viable conversion error fix(yabloc): suppress no viable conversion error Jun 7, 2024
@KYabuuchi
Copy link
Contributor Author

@SakodaShintaro Thank you for the review. 🙇
Here are the details of the changes I made (I also added this to the PR description):

  • Used static_cast for explicit type conversion
  • Used the direct creation of ColorRGBA with tier4_autoware_utils::createMarkerColor

Also, I fixed the issue of semantic-pull-request, and the typo "()" in the PR description.

Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!
Looks Good To Me

@KYabuuchi KYabuuchi merged commit cc9512b into autowarefoundation:main Jun 7, 2024
36 of 45 checks passed
@KYabuuchi KYabuuchi deleted the fix/yabloc_no_viable_conversion branch June 7, 2024 04:03
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
* use tier4_autoware_utils instead of yabloc::Color

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

* use static_cast to convert Color to RGBA

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

* use tier4_autoware_utils instead of yabloc::Color

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

* use static_cast to convert Color to RGBA

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants