-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(yabloc): suppress no viable conversion error #7299
Merged
KYabuuchi
merged 6 commits into
autowarefoundation:main
from
KYabuuchi:fix/yabloc_no_viable_conversion
Jun 7, 2024
Merged
fix(yabloc): suppress no viable conversion error #7299
KYabuuchi
merged 6 commits into
autowarefoundation:main
from
KYabuuchi:fix/yabloc_no_viable_conversion
Jun 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
…KYabuuchi/autoware.universe into fix/yabloc_no_viable_conversion
KYabuuchi
added
the
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Jun 6, 2024
github-actions
bot
added
the
component:localization
Vehicle's position determination in its environment. (auto-assigned)
label
Jun 6, 2024
KYabuuchi
requested review from
anhnv3991,
Motsu-san,
RyuYamamoto,
SakodaShintaro,
TaikiYamada4 and
YamatoAndo
as code owners
June 6, 2024 08:09
KYabuuchi
changed the title
fix(yabloc) : suppress no viable conversion error
fix(yabloc): suppress no viable conversion error
Jun 7, 2024
@SakodaShintaro Thank you for the review. 🙇
Also, I fixed the issue of semantic-pull-request, and the typo "()" in the PR description. |
SakodaShintaro
approved these changes
Jun 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fix!
Looks Good To Me
3 tasks
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
* use tier4_autoware_utils instead of yabloc::Color Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * use static_cast to convert Color to RGBA Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * use tier4_autoware_utils instead of yabloc::Color Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * use static_cast to convert Color to RGBA Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * style(pre-commit): autofix --------- Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:localization
Vehicle's position determination in its environment. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I suppressed the warnings reported in #7210
Some other warnings still remain. Only the "no viable conversion error" has been resolved.
To resolve
no viable conversion
error I made the following changestatic_cast
for explicit type conversiontier4_autoware_utils::createMarkerColor
Tests performed
Confirm that the error has been resolved by comparing the outputs of clang-tidy.
Below, I have provided links to the previous clang-tidy's outputs and those generated by this PR.
(produced by here)
(produced by here)
Confirmed that yabloc works as conventional in logging_simulator
Effects on system behavior
This PR does not change the system behavior.
Interface changes
Interface does not change.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.