Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tier4_map_launch): change log output #7289

Merged

Conversation

a-maumau
Copy link
Contributor

@a-maumau a-maumau commented Jun 6, 2024

Description

This PR is to ensure the log output from the node in the container will log in log file.

Changed log output from screen to both for launch file in tier4_map_launch/map.launch.xml.
This change is for #7203

Tests performed

Confirmed checking the log file:

1717636937.9026053 [component_container_mt-28] terminate called after throwing an instance of 'std::runtime_error'
1717636937.9034562 [component_container_mt-28]   what():  THROWING RUNTIME ERROR
1717636937.9036062 [component_container_mt-28] *** Aborted at 1717636937 (unix time) try "date -d @1717636937" if you are using GNU date ***
1717636937.9036851 [component_container_mt-28] PC: @                0x0 (unknown)
1717636937.9038866 [component_container_mt-28] *** SIGABRT (@0x3e8000b353e) received by PID 734526 (TID 0x7f2a7f7fe640) from PID 734526; stack trace: ***
1717636937.9039729 [component_container_mt-28]     @     0x7f2a93a1a4d6 google::(anonymous namespace)::FailureSignalHandler()
1717636937.9041173 [component_container_mt-28]     @     0x7f2a92e42520 (unknown)
1717636937.9041913 [component_container_mt-28]     @     0x7f2a92e969fc pthread_kill
1717636937.9042599 [component_container_mt-28]     @     0x7f2a92e42476 raise
1717636937.9144201 [component_container_mt-78] [INFO] [1717636937.885660050] [control.control_container]: Found class: rclcpp_components::NodeFactoryTemplate<autoware::motion::control::trajectory_follower_node::Controller>
1717636937.9146867 [component_container_mt-78] [INFO] [1717636937.885808062] [control.control_container]: Instantiate class: rclcpp_components::NodeFactoryTemplate<autoware::motion::control::trajectory_follower_node::Controller>
1717636937.9157732 [component_container_mt-61] [INFO] [1717636937.890994692] [perception.traffic_light_recognition.camera6.traffic_light_node_container]: Found class: rclcpp_components::NodeFactoryTemplate<image_preprocessor::ImageTransportDecompressor>
1717636937.9159813 [component_container_mt-61] [INFO] [1717636937.891071597] [perception.traffic_light_recognition.camera6.traffic_light_node_container]: Instantiate class: rclcpp_components::NodeFactoryTemplate<image_preprocessor::ImageTransportDecompressor>
1717636937.9170609 [component_container_mt-28]     @     0x7f2a92e287f3 abort
1717636937.9172404 [component_container_mt-28]     @     0x7f2a932a2b9e (unknown)
1717636937.9173703 [component_container_mt-28]     @     0x7f2a932ae20c (unknown)
1717636937.9174886 [component_container_mt-28]     @     0x7f2a932ae277 std::terminate()
1717636937.9653187 [INFO] [launch_ros.actions.load_composable_nodes]: Loaded node '/autoware_api/external/rtc_controller/node' in container '/autoware_api/external/rtc_controller/container'
1717636937.9715085 [INFO] [launch_ros.actions.load_composable_nodes]: Loaded node '/map/lanelet2_map_visualization' in container '/map/map_container'
1717636937.9761968 [component_container_mt-28] [INFO] [1717636937.975519822] [map.map_container]: Load Library: /home/masakibaba/autoware/install/map_tf_generator/lib/libvector_map_tf_generator_node.so
1717636937.9952533 [component_container_mt-28]     @     0x7f2a932ae4d8 __cxa_throw
1717636937.9964249 [component_container_mt-28]     @     0x7f2a87e7f83c Lanelet2MapLoaderNode::load_map()
1717636938.0059855 [component_container_mt-28]     @     0x7f2a87e88339 Lanelet2MapLoaderNode::on_map_projector_info()
1717636938.0077431 [component_container_mt-28]     @     0x7f2a87e88c43 _ZNSt17_Function_handlerIFvSt10shared_ptrIKN14tier4_map_msgs3msg17MapProjectorInfo_ISaIvEEEEEZN21Lanelet2MapLoaderNodeC4ERKN6rclcpp11NodeOptionsEEUlS7_E_E9_M_invokeERKSt9_Any_dataOS7_
1717636938.0091989 [component_container_mt-28] [INFO] [1717636938.006921425] [map.map_container]: Found class: rclcpp_components::NodeFactoryTemplate<VectorMapTFGeneratorNode>
1717636938.0093501 [component_container_mt-28] [INFO] [1717636938.006971022] [map.map_container]: Instantiate class: rclcpp_components::NodeFactoryTemplate<VectorMapTFGeneratorNode>
1717636938.0107651 [component_container_mt-28]     @     0x7f2a87e987a7 _ZNSt8__detail9__variant17__gen_vtable_implINS0_12_Multi_arrayIPFNS0_21__deduce_visit_resultIvEEOZN6rclcpp23AnySubscriptionCallbackIN14tier4_map_msgs3msg17MapProjectorInfo_ISaIvEEESA_E8dispatchESt10shared_ptrISB_ERKNS5_11MessageInfoEEUlOT_E_RSt7va\
riantIJSt8functionIFvRKSB_EESN_IFvSP_SH_EESN_IFvRKNS5_17SerializedMessageEEESN_IFvSW_SH_EESN_IFvSt10unique_ptrISB_St14default_deleteISB_EEEESN_IFvS14_SH_EESN_IFvS11_ISU_S12_ISU_EEEESN_IFvS1A_SH_EESN_IFvSD_ISO_EEESN_IFvS1F_SH_EESN_IFvSD_ISV_EEESN_IFvS1K_SH_EESN_IFvRKS1F_EESN_IFvS1Q_SH_EESN_IFvRKS1K_EESN_IFvS1W_SH_EESN_\
IFvSE_EESN_IFvSE_SH_EESN_IFvSD_ISU_EEESN_IFvS25_SH_EEEEEJEEESt16integer_sequenceImJLm8EEEE14__visit_invokeESL_S2B_
1717636938.0120451 [component_container_mt-28]     @     0x7f2a87ea9a45 rclcpp::Subscription<>::handle_message()
1717636938.0424185 [component_container_mt-28]     @     0x7f2a9375dba0 rclcpp::Executor::execute_subscription()
1717636938.0450542 [component_container_mt-28]     @     0x7f2a9375f10e rclcpp::Executor::execute_any_executable()
1717636938.0453181 [component_container_mt-28]     @     0x7f2a93765432 rclcpp::executors::MultiThreadedExecutor::run()
...
1717636938.2300518 [ERROR] [component_container_mt-28]: process has died ...

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
@SakodaShintaro SakodaShintaro added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 6, 2024
Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should have waited a bit longer in the original pull request. I'm sorry I merged that without checking.

There's nothing wrong with this PR.
Looks Good To Me

@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Jun 6, 2024
@SakodaShintaro SakodaShintaro merged commit da95336 into autowarefoundation:main Jun 6, 2024
24 of 25 checks passed
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jun 6, 2024
change log output from screen to both

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Co-authored-by: SakodaShintaro <shintaro.sakoda@tier4.jp>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
change log output from screen to both

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Co-authored-by: SakodaShintaro <shintaro.sakoda@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants