refactor(mrm_handler): use switch for state machine #7277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:system
danielsanchezaran
force-pushed
the
refactor/mrm_handler
branch
from
220dd3d to
024882e
Compare
danielsanchezaran
added
run:build-and-test-differential
danielsanchezaran
requested review from
mkuri,
veqcc and
TetsuKawa
as code owners
veqcc
approved these changes
Jun 6, 2024
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
danielsanchezaran
force-pushed
the
refactor/mrm_handler
branch
from
6d14efd to
dd53b03
Compare
danielsanchezaran
changed the title
danielsanchezaran
merged commit 7d69e00
into
autowarefoundation:main
24 of 27 checks passed
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
* refactor nested if elses Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * delete other commits Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * return for consistency Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> --------- Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor the state machine
Tests performed
PSim
Not applicable.
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.