Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(obstacle_curise): revert lateral stop margin for unknown objects #7230

Merged

Conversation

yuki-takagi-66
Copy link
Contributor

@yuki-takagi-66 yuki-takagi-66 commented Jun 3, 2024

Description

disable a recent implemented feature

Tests performed

psim

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@yuki-takagi-66 yuki-takagi-66 changed the title update feat(obstacle_curise): disable a feature Jun 3, 2024
@yuki-takagi-66 yuki-takagi-66 marked this pull request as ready for review June 3, 2024 05:26
@yuki-takagi-66 yuki-takagi-66 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 3, 2024
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jun 3, 2024
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 7.56%. Comparing base (3d849e9) to head (b1de4fa).
Report is 159 commits behind head on main.

Current head b1de4fa differs from pull request most recent head ea29a80

Please upload reports for the commit ea29a80 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #7230       +/-   ##
==========================================
- Coverage   15.09%   7.56%    -7.53%     
==========================================
  Files        1967      18     -1949     
  Lines      135941    2379   -133562     
  Branches    42122    1287    -40835     
==========================================
- Hits        20520     180    -20340     
+ Misses      92700    1865    -90835     
+ Partials    22721     334    -22387     
Flag Coverage Δ
differential 7.56% <ø> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@takayuki5168 takayuki5168 changed the title feat(obstacle_curise): disable a feature feat(obstacle_curise): revert lateral stop margin for unknown objects Jun 3, 2024
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
@yuki-takagi-66 yuki-takagi-66 force-pushed the feat/cruise/disable-a-feature branch from b1de4fa to ea29a80 Compare June 6, 2024 06:21
@yuki-takagi-66 yuki-takagi-66 merged commit d54e1ff into autowarefoundation:main Jun 7, 2024
23 of 25 checks passed
@yuki-takagi-66 yuki-takagi-66 deleted the feat/cruise/disable-a-feature branch June 7, 2024 04:22
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants