Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vehicle_velocity_converter): componentize VehicleVelocityConverter #7116

Conversation

a-maumau
Copy link
Contributor

@a-maumau a-maumau commented May 24, 2024

Description

Componentize the node in sensing/vehicle_velocity_converter.
(Add glog feature to sensing/vehicle_velocity_converter)

Also, log output is changed from "screen" to "both".

Tests performed

Confirmed that terminating the vehicle_velocity_converter process will output logs to both the terminal and the log file.

...
1716535733.2051744 [vehicle_velocity_converter_node-36] [INFO] [1716535733.204828147] [rclcpp]: signal_handler(signum=15)
1716535733.2052956 [vehicle_velocity_converter_node-36] *** Aborted at 1716535733 (unix time) try "date -d @1716535733" if you are using GNU date ***
1716535733.2058232 [vehicle_velocity_converter_node-36] PC: @                0x0 (unknown)
1716535733.2062550 [vehicle_velocity_converter_node-36] *** SIGTERM (@0x3e8001c1f43) received by PID 3241499 (TID 0x7fb9a8b52680) from PID 1843011; stack trace: ***
1716535733.2067599 [vehicle_velocity_converter_node-36]     @     0x7fb9a93f04d6 google::(anonymous namespace)::FailureSignalHandler()
1716535733.2071424 [vehicle_velocity_converter_node-36]     @     0x7fb9a9219ded rclcpp::SignalHandler::signal_handler()
1716535733.2075086 [vehicle_velocity_converter_node-36]     @     0x7fb9a8842520 (unknown)
1716535733.2076995 [vehicle_velocity_converter_node-36]     @     0x7fb9a8891117 (unknown)
1716535733.2079968 [vehicle_velocity_converter_node-36]     @     0x7fb9a8893a41 pthread_cond_wait
1716535733.2080512 [vehicle_velocity_converter_node-36]     @     0x7fb9a8784a8d ddsrt_cond_wait
1716535733.2080932 [vehicle_velocity_converter_node-36]     @     0x7fb9a8784b55 ddsrt_cond_waituntil
1716535733.2081316 [vehicle_velocity_converter_node-36]     @     0x7fb9a876b45d (unknown)
1716535733.2084649 [vehicle_velocity_converter_node-36]     @     0x7fb9a8afb74f rmw_wait
1716535733.2085304 [vehicle_velocity_converter_node-36]     @     0x7fb9a92f2848 rcl_wait
1716535733.2088835 [vehicle_velocity_converter_node-36]     @     0x7fb9a91611b6 rclcpp::Executor::wait_for_work()
1716535733.2092392 [vehicle_velocity_converter_node-36]     @     0x7fb9a91616d3 rclcpp::Executor::get_next_executable()
1716535733.2095973 [vehicle_velocity_converter_node-36]     @     0x7fb9a9165c81 rclcpp::executors::SingleThreadedExecutor::spin()
1716535733.2096522 [vehicle_velocity_converter_node-36]     @     0x55e3a5dcf486 main
1716535733.2101130 [vehicle_velocity_converter_node-36]     @     0x7fb9a8829d90 (unknown)
1716535733.2103839 [vehicle_velocity_converter_node-36]     @     0x7fb9a8829e40 __libc_start_main
1716535733.2104459 [vehicle_velocity_converter_node-36]     @     0x55e3a5dcfe35 _start
1716535733.2113101 [ERROR] [vehicle_velocity_converter_node-36]: process has died ...(omitted)

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

a-maumau added 3 commits May 24, 2024 16:36
Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
@a-maumau a-maumau requested a review from RyuYamamoto as a code owner May 24, 2024 07:46
@github-actions github-actions bot added the component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) label May 24, 2024
Copy link
Contributor

@RyuYamamoto RyuYamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YamatoAndo YamatoAndo added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label May 31, 2024
@YamatoAndo YamatoAndo merged commit 5006a4d into autowarefoundation:main Jun 6, 2024
23 of 25 checks passed
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
…er (#7116)

* remove unusing main func file

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* mod to componentize and use glog

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* change log output from screen to both

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

---------

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Co-authored-by: Yamato Ando <yamato.ando@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants