perf(route_handler): simplify queries on the road and shoulder lanelets #6885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:planning
maxime-clem
force-pushed
the
perf/route_handler-rm_road_lanelets
branch
3 times, most recently
from
2ae0949 to
fb992b4
Compare
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
also improve isShoulderLanelet (replace is_road_shoulder) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
using the routing graph did not work Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
maxime-clem
force-pushed
the
perf/route_handler-rm_road_lanelets
branch
from
cfa9ed9 to
3a4d940
Compare
maxime-clem
changed the title
maxime-clem
requested review from
kosuke55,
takayuki5168,
rej55,
soblin,
zulfaqar-azmi-t4,
danielsanchezaran,
kyoichi-sugahara and
satoshi-ota
as code owners
maxime-clem
requested review from
shmpwk,
TomohitoAndo,
tkimura4 and
TakaHoribe
as code owners
kyoichi-sugahara
approved these changes
Apr 30, 2024
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
|
wow! thanks!! |
maxime-clem
added
the
run:build-and-test-differential
zulfaqar-azmi-t4
approved these changes
May 8, 2024
kosuke55
approved these changes
May 8, 2024
vividf
pushed a commit
to vividf/autoware.universe
that referenced
this pull request
May 16, 2024
…ts (autowarefoundation#6885) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp> Signed-off-by: vividf <yihsiang.fang@tier4.jp>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…ts (autowarefoundation#6885) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
satoshi-ota
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Jun 6, 2024
…ts (autowarefoundation#6885) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, some functions are performing queries on ALL shoulder or road lanelets of the map.
With very large maps, this leads to performance issues which are solved by this PR.
Tests performed
Evaluator (TIER IV INTERNAL LINK): https://evaluation.tier4.jp/evaluation/reports/7a9c88f8-9724-57ba-a7cf-568b385f18f6?project_id=prd_jt
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.