Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(avoidance): bug in the logic to judge whether it's a parked vehicle #6768

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Apr 9, 2024

Description

The avoidance module couldn't create avoidance path in following situation. The module makes avoidance path for object on the ego's lane only when it's a parked vehicle. And, it assumed there is no parked vehicle on ego's lane if the lane has both right and left adjacent lane.

On the other hand, if the right or left lane is a road shoulder lane, there is a possibility that there is parked vehicle on ego's lane. (if it is a large vehicle and the road should is narrow, maybe the vehicles position is on ego's lane.)

However, since previous avoidance module considered the road shoudler lanes as road lanes, the module didn't create avoidance path in following situation.

image

In this PR, I fixed the argument in order not to get adjacent road shoulder lanelet in following function.

    const auto right_lane =
      planner_data->route_handler->getRightLanelet(object.overhang_lanelet, true, false);
    const auto left_lane =
      planner_data->route_handler->getLeftLanelet(object.overhang_lanelet, true, false);

image

Additionally, this PR includes small refactoring as well (remove unused function getTargetLanelets).

Tests performed

Effects on system behavior

Fix bug.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Apr 9, 2024
@satoshi-ota satoshi-ota changed the title fix(avoidance): adjacent lane check for ambiguous stopped vehicle fix(avoidance): bug in the logic to judge whether it's a parked vehicle Apr 9, 2024
@satoshi-ota satoshi-ota marked this pull request as ready for review April 9, 2024 01:34
@shmpwk shmpwk added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Apr 9, 2024
Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshi-ota satoshi-ota merged commit 9cbd02d into autowarefoundation:main Apr 9, 2024
55 of 57 checks passed
@satoshi-ota satoshi-ota deleted the fix/adjacent-lane-check branch April 9, 2024 11:59
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Apr 9, 2024
…le (autowarefoundation#6768)

fix(avoidance): adjacent lane check for ambiguous stopped vehicle

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Apr 10, 2024
…le (autowarefoundation#6768)

fix(avoidance): adjacent lane check for ambiguous stopped vehicle

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Apr 10, 2024
…le (autowarefoundation#6768)

fix(avoidance): adjacent lane check for ambiguous stopped vehicle

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Apr 18, 2024
…le (autowarefoundation#6768)

fix(avoidance): adjacent lane check for ambiguous stopped vehicle

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…le (autowarefoundation#6768)

fix(avoidance): adjacent lane check for ambiguous stopped vehicle

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants