-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(avoidance): bug in the logic to judge whether it's a parked vehicle #6768
Merged
satoshi-ota
merged 1 commit into
autowarefoundation:main
from
tier4:fix/adjacent-lane-check
Apr 9, 2024
Merged
fix(avoidance): bug in the logic to judge whether it's a parked vehicle #6768
satoshi-ota
merged 1 commit into
autowarefoundation:main
from
tier4:fix/adjacent-lane-check
Apr 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
shmpwk
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
satoshi-ota
added a commit
to tier4/autoware.universe
that referenced
this pull request
Apr 9, 2024
…le (autowarefoundation#6768) fix(avoidance): adjacent lane check for ambiguous stopped vehicle Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota
added a commit
to tier4/autoware.universe
that referenced
this pull request
Apr 10, 2024
…le (autowarefoundation#6768) fix(avoidance): adjacent lane check for ambiguous stopped vehicle Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
4 tasks
satoshi-ota
added a commit
to tier4/autoware.universe
that referenced
this pull request
Apr 10, 2024
…le (autowarefoundation#6768) fix(avoidance): adjacent lane check for ambiguous stopped vehicle Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
4 tasks
satoshi-ota
added a commit
to tier4/autoware.universe
that referenced
this pull request
Apr 18, 2024
…le (autowarefoundation#6768) fix(avoidance): adjacent lane check for ambiguous stopped vehicle Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…le (autowarefoundation#6768) fix(avoidance): adjacent lane check for ambiguous stopped vehicle Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The avoidance module couldn't create avoidance path in following situation. The module makes avoidance path for object on the ego's lane only when it's a parked vehicle. And, it assumed there is no parked vehicle on ego's lane if the lane has both right and left adjacent lane.
On the other hand, if the right or left lane is a road shoulder lane, there is a possibility that there is parked vehicle on ego's lane. (if it is a large vehicle and the road should is narrow, maybe the vehicles position is on ego's lane.)
However, since previous avoidance module considered the road shoudler lanes as road lanes, the module didn't create avoidance path in following situation.
In this PR, I fixed the argument in order not to get adjacent road shoulder lanelet in following function.
Additionally, this PR includes small refactoring as well (remove unused function
getTargetLanelets
).Tests performed
Effects on system behavior
Fix bug.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.