Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): fix behavior_path_planner node to check occupancy_grid before running #6752

Merged

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Apr 5, 2024

Description

check occupancy_grid_map before running behavior_path_planner node.

Related links

Tests performed

https://evaluation.tier4.jp/evaluation/reports/05b6788e-9aac-56da-8989-6fe2229ff7da?project_id=prd_jt

Notes for reviewers

Interface changes

none

Effects on system behavior

none

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

…ccupancy_grid before running

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Apr 5, 2024
@soblin soblin marked this pull request as ready for review April 5, 2024 08:27
Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok if no problem for x1/s1

@shmpwk shmpwk added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Apr 5, 2024
@soblin soblin enabled auto-merge (squash) April 5, 2024 09:57
@shmpwk shmpwk added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Apr 8, 2024
Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soblin soblin merged commit 1524bdd into autowarefoundation:main Apr 8, 2024
38 of 41 checks passed
@soblin soblin deleted the fix/behavior_path/check-occupancy-grid branch April 8, 2024 09:17
esteve pushed a commit that referenced this pull request Apr 9, 2024
…ccupancy_grid before running (#6752)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
shmpwk pushed a commit to tier4/autoware.universe that referenced this pull request May 9, 2024
…ccupancy_grid before running (autowarefoundation#6752)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
shmpwk pushed a commit to tier4/autoware.universe that referenced this pull request May 9, 2024
…ccupancy_grid before running (autowarefoundation#6752)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
shmpwk pushed a commit to tier4/autoware.universe that referenced this pull request May 10, 2024
…ccupancy_grid before running (autowarefoundation#6752)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
soblin added a commit to tier4/autoware.universe that referenced this pull request May 16, 2024
…ccupancy_grid before running (autowarefoundation#6752)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…ccupancy_grid before running (autowarefoundation#6752)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants