Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(intersection): fix possible invalid access #6542

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Mar 5, 2024

Description

add size check

Related links

autowarefoundation/autoware_common#240

Tests performed

This issue is possible if the map contained a lanelet linestring with no points.

Notes for reviewers

Interface changes

none

Effects on system behavior

none

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Mar 5, 2024
@soblin soblin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 5, 2024
@soblin soblin enabled auto-merge (squash) March 5, 2024 06:09
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 15.19%. Comparing base (833722b) to head (b7ab598).
Report is 5 commits behind head on main.

Files Patch % Lines
...tersection_module/src/scene_intersection_stuck.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6542      +/-   ##
==========================================
- Coverage   15.19%   15.19%   -0.01%     
==========================================
  Files        1851     1851              
  Lines      128449   128451       +2     
  Branches    39228    39230       +2     
==========================================
  Hits        19519    19519              
- Misses      87138    87140       +2     
  Partials    21792    21792              
Flag Coverage Δ *Carryforward flag
differential 4.49% <0.00%> (?)
total 15.19% <ø> (ø) Carriedforward from 833722b

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soblin soblin merged commit a6003cf into autowarefoundation:main Mar 5, 2024
29 of 32 checks passed
@soblin soblin deleted the fix/intersection/possible-invalid-access branch March 5, 2024 06:36
shmpwk pushed a commit to tier4/autoware.universe that referenced this pull request Mar 5, 2024
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
YoshiRi pushed a commit to tier4/autoware.universe that referenced this pull request Mar 11, 2024
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
HansRobo pushed a commit that referenced this pull request Mar 12, 2024
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
kaigohirao pushed a commit to kaigohirao/autoware.universe that referenced this pull request Mar 22, 2024
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: kaigohirao <kaigo.hirao@proxima-ai-tech.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
soblin added a commit to tier4/autoware.universe that referenced this pull request Oct 23, 2024
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
soblin added a commit to tier4/autoware.universe that referenced this pull request Oct 23, 2024
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
saka1-s pushed a commit to saka1-s/autoware.universe that referenced this pull request Nov 9, 2024
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants