-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(traffic_light): depend on is_simulation for scenario simulator #6498
feat(traffic_light): depend on is_simulation for scenario simulator #6498
Conversation
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
// in the simulation, it will PASS to prevent stopping on the planning simulator | ||
// or scenario simulator. | ||
// in the real environment, it will STOP for safety in cases such that traffic light | ||
// recognition is not working properly or the map is incorrect. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unnecessary space
// recognition is not working properly or the map is incorrect. | |
// recognition is not working properly or the map is incorrect. |
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6498 +/- ##
==========================================
- Coverage 14.64% 14.64% -0.01%
==========================================
Files 1899 1899
Lines 130283 130279 -4
Branches 38311 38312 +1
==========================================
- Hits 19082 19081 -1
+ Misses 89785 89781 -4
- Partials 21416 21417 +1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…utowarefoundation#6498) * feat(traffic_light): depend on is_simulation for scenario simulator Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix comments Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
#1171) feat(traffic_light): depend on is_simulation for scenario simulator (autowarefoundation#6498) * feat(traffic_light): depend on is_simulation for scenario simulator * fix comments * fix --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
…6498) * feat(traffic_light): depend on is_simulation for scenario simulator Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix comments Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
#1171) feat(traffic_light): depend on is_simulation for scenario simulator (autowarefoundation#6498) * feat(traffic_light): depend on is_simulation for scenario simulator * fix comments * fix --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
…utowarefoundation#6498) * feat(traffic_light): depend on is_simulation for scenario simulator Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix comments Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Description
This PR extends the feature to deal with the traffic signal depending on whether it's a simulation or not, implemented in the following PR.
#6468
Regarding the Autoware's planning behavior for the traffic signal, we have the following three requirements.
The problem is that, even though the assumption that the traffic signal topic is always published is the same in the scenario simulator and the real environment, the expected Autoware behaviors are not the same.
In this PR, we introduce the new variable
is_simulation
in autoware_launch so that the Autoware will know that the current environment is the simulator or not, and the above problem can be fixed.launch PR
Tests performed
unit test
scenario test: https://evaluation.tier4.jp/evaluation/reports/e4aec1b1-abc6-5d28-9d63-ab7822b1f173?project_id=prd_jt
Effects on system behavior
The scenario tests will pass without designating all the traffic signal colors in the scenario files.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.