Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(traffic_light): depend on is_simulation for scenario simulator #6498

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Feb 27, 2024

Description

This PR extends the feature to deal with the traffic signal depending on whether it's a simulation or not, implemented in the following PR.
#6468

Regarding the Autoware's planning behavior for the traffic signal, we have the following three requirements.

  • planning simulator
    • By default, the traffic signal topic is NOT published.
    • The ego does not want to stop at the traffic signal.
  • scenario simulator
    • The traffic signal topic is always published.
    • The ego does NOT want to stop at the traffic signal where the color is not contained in the topic.
  • real environment
    • The traffic signal topic is always published.
    • The ego wants to stop at the traffic signal where the color is not contained in the topic for safety in cases such that traffic light recognition is not working properly or the map is incorrect

The problem is that, even though the assumption that the traffic signal topic is always published is the same in the scenario simulator and the real environment, the expected Autoware behaviors are not the same.

In this PR, we introduce the new variable is_simulation in autoware_launch so that the Autoware will know that the current environment is the simulator or not, and the above problem can be fixed.

launch PR

Tests performed

unit test
scenario test: https://evaluation.tier4.jp/evaluation/reports/e4aec1b1-abc6-5d28-9d63-ab7822b1f173?project_id=prd_jt

Effects on system behavior

The scenario tests will pass without designating all the traffic signal colors in the scenario files.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@github-actions github-actions bot added component:planning Route planning, decision-making, and navigation. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Feb 27, 2024
@takayuki5168 takayuki5168 marked this pull request as ready for review February 27, 2024 04:24
@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 27, 2024
// in the simulation, it will PASS to prevent stopping on the planning simulator
// or scenario simulator.
// in the real environment, it will STOP for safety in cases such that traffic light
// recognition is not working properly or the map is incorrect.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unnecessary space

Suggested change
// recognition is not working properly or the map is incorrect.
// recognition is not working properly or the map is incorrect.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 14.64%. Comparing base (209b672) to head (b755637).
Report is 14 commits behind head on main.

Files Patch % Lines
planning/behavior_velocity_planner/src/node.cpp 0.00% 0 Missing and 1 partial ⚠️
..._velocity_planner/test/src/test_node_interface.cpp 0.00% 0 Missing and 1 partial ⚠️
...havior_velocity_traffic_light_module/src/scene.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6498      +/-   ##
==========================================
- Coverage   14.64%   14.64%   -0.01%     
==========================================
  Files        1899     1899              
  Lines      130283   130279       -4     
  Branches    38311    38312       +1     
==========================================
- Hits        19082    19081       -1     
+ Misses      89785    89781       -4     
- Partials    21416    21417       +1     
Flag Coverage Δ *Carryforward flag
differential 11.46% <0.00%> (?)
total 14.64% <ø> (+<0.01%) ⬆️ Carriedforward from 209b672

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@takayuki5168 takayuki5168 merged commit 4d02841 into autowarefoundation:main Feb 29, 2024
20 of 23 checks passed
@takayuki5168 takayuki5168 deleted the feat/is-simulation-for-traffic-signal branch February 29, 2024 02:51
TomohitoAndo pushed a commit to tier4/autoware.universe that referenced this pull request Mar 5, 2024
…utowarefoundation#6498)

* feat(traffic_light): depend on is_simulation for scenario simulator

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix comments

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
TomohitoAndo added a commit to tier4/autoware.universe that referenced this pull request Mar 8, 2024
#1171)

feat(traffic_light): depend on is_simulation for scenario simulator (autowarefoundation#6498)

* feat(traffic_light): depend on is_simulation for scenario simulator



* fix comments



* fix



---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
HansRobo pushed a commit that referenced this pull request Mar 12, 2024
…6498)

* feat(traffic_light): depend on is_simulation for scenario simulator

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix comments

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
TomohitoAndo added a commit to tier4/autoware.universe that referenced this pull request Apr 11, 2024
#1171)

feat(traffic_light): depend on is_simulation for scenario simulator (autowarefoundation#6498)

* feat(traffic_light): depend on is_simulation for scenario simulator

* fix comments

* fix

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…utowarefoundation#6498)

* feat(traffic_light): depend on is_simulation for scenario simulator

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix comments

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants