-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lane_departure_checker,start_planner): add check for path within lanes for bvspm #6366
feat(lane_departure_checker,start_planner): add check for path within lanes for bvspm #6366
Conversation
9098aa3
to
5305676
Compare
9ffbc69
to
3b49562
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6366 +/- ##
==========================================
- Coverage 14.63% 14.63% -0.01%
==========================================
Files 1900 1900
Lines 130645 130689 +44
Branches 38381 38733 +352
==========================================
+ Hits 19123 19124 +1
- Misses 90064 90107 +43
Partials 21458 21458
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@danielsanchezaran |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!Thanks!!!!!
Thank you for your reply, for reference here are the evaluation results we discussed about TIER IV INTERNAL LINK |
127a293
to
daf0db5
Compare
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
daf0db5
to
6208d4f
Compare
I've canceled the This PR halves the time required for build-and-test-differential checks: If the test passes, it will be merged automatically, you don't need to do anything. If you make any further changes to this PR, please rebase to main. |
0042c20
into
autowarefoundation:main
… lanes for bvspm (autowarefoundation#6366) * WIP add new methods for lane departure checker Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add lanelet polygon check for lane departure Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * use new checkPathWillLeaveLane function Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * working solution, fix union bug Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * Add check fo backwards path Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * delete departure check lanes Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add lane departure check to geometric pullout Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * merge all union polygon Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * pre-commit changes Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * move the cheap/fast check first to possibly boost performance Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> --------- Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> Co-authored-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
… lanes for bvspm (autowarefoundation#6366) * WIP add new methods for lane departure checker Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add lanelet polygon check for lane departure Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * use new checkPathWillLeaveLane function Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * working solution, fix union bug Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * Add check fo backwards path Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * delete departure check lanes Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add lane departure check to geometric pullout Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * merge all union polygon Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * pre-commit changes Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * move the cheap/fast check first to possibly boost performance Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> --------- Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> Co-authored-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
… lanes for bvspm (autowarefoundation#6366) (#1165) * feat(lane_departure_checker,start_planner): add check for path within lanes for bvspm (autowarefoundation#6366) * WIP add new methods for lane departure checker Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add lanelet polygon check for lane departure Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * use new checkPathWillLeaveLane function Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * working solution, fix union bug Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * Add check fo backwards path Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * delete departure check lanes Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add lane departure check to geometric pullout Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * merge all union polygon Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * pre-commit changes Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * move the cheap/fast check first to possibly boost performance Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> --------- Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> Co-authored-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * style(pre-commit): autofix --------- Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> Co-authored-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
… lanes for bvspm (#6366) * WIP add new methods for lane departure checker Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add lanelet polygon check for lane departure Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * use new checkPathWillLeaveLane function Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * working solution, fix union bug Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * Add check fo backwards path Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * delete departure check lanes Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add lane departure check to geometric pullout Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * merge all union polygon Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * pre-commit changes Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * move the cheap/fast check first to possibly boost performance Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> --------- Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> Co-authored-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
… lanes for bvspm (autowarefoundation#6366) * WIP add new methods for lane departure checker Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add lanelet polygon check for lane departure Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * use new checkPathWillLeaveLane function Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * working solution, fix union bug Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * Add check fo backwards path Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * delete departure check lanes Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add lane departure check to geometric pullout Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * merge all union polygon Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * pre-commit changes Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * move the cheap/fast check first to possibly boost performance Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> --------- Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> Co-authored-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
… lanes for bvspm (autowarefoundation#6366) * WIP add new methods for lane departure checker Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add lanelet polygon check for lane departure Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * use new checkPathWillLeaveLane function Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * working solution, fix union bug Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * Add check fo backwards path Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * delete departure check lanes Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add lane departure check to geometric pullout Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * merge all union polygon Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * pre-commit changes Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * move the cheap/fast check first to possibly boost performance Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> --------- Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> Co-authored-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
… (cherry pick 8bdb542 and 0042c20) (#1220) * feat(lane_departure_checker,start_planner): add check for path within lanes for bvspm (autowarefoundation#6366) * WIP add new methods for lane departure checker Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add lanelet polygon check for lane departure Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * use new checkPathWillLeaveLane function Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * working solution, fix union bug Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * Add check fo backwards path Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * delete departure check lanes Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add lane departure check to geometric pullout Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * merge all union polygon Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * pre-commit changes Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * move the cheap/fast check first to possibly boost performance Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> --------- Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> Co-authored-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * declare missing function Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * fix(lane_departure_checker): empty lanelet polygon (autowarefoundation#6588) * fix union sometimes returning empty polygon Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * fix union of polygons Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * fix back launcher Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> --------- Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * cherry pick 8bdb542 and 0042c20 from universe Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * remove unused methods Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> --------- Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> Co-authored-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
… lanes for bvspm (autowarefoundation#6366) * WIP add new methods for lane departure checker Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add lanelet polygon check for lane departure Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * use new checkPathWillLeaveLane function Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * working solution, fix union bug Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * Add check fo backwards path Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * delete departure check lanes Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add lane departure check to geometric pullout Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * merge all union polygon Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * pre-commit changes Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * move the cheap/fast check first to possibly boost performance Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> --------- Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> Co-authored-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
… lanes for bvspm (autowarefoundation#6366) * WIP add new methods for lane departure checker Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add lanelet polygon check for lane departure Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * use new checkPathWillLeaveLane function Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * working solution, fix union bug Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * Add check fo backwards path Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * delete departure check lanes Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add lane departure check to geometric pullout Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * merge all union polygon Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * pre-commit changes Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * move the cheap/fast check first to possibly boost performance Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> --------- Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> Co-authored-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Description
In this PR, a new departure check set of functions have been added to lane_departure_checker that:
I have implemented this check for shift pull out and geometric pull out to improve and be able to consider all the necessary lanelets to do a proper out of lane check. This solves the issue in which the ego vehicle cannot start with a shift pull out on overlapped lanes:
Before, the shift pull out planner cannot generate a route when the ego overlaps more than one lane (other planners are disabled):
After the changes on this PR:
Related links
Tests performed
Tests performed: Psim and Scenario tests: TIER IV INTERNAL LINK , degradation seems to be caused by an unrelated problem with this PR.
Notes for reviewers
Interface changes
Effects on system behavior
Checked lanes for lane departure are increased to involve all relevant lanelets for the start planner.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.