fix(intersection_occlusion): fix for PR6273 without traffic light #6335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 80a271f.
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
github-actions
bot
added
the
component:planning
soblin
requested review from
kyoichi-sugahara,
shmpwk,
takayuki5168 and
tkimura4
as code owners
takayuki5168
approved these changes
Feb 6, 2024
takayuki5168
added
the
run:build-and-test-differential
anhnv3991
pushed a commit
to anhnv3991/autoware.universe
that referenced
this pull request
Feb 13, 2024
…towarefoundation#6335) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
StepTurtle
pushed a commit
to StepTurtle/autoware.universe
that referenced
this pull request
Feb 28, 2024
…towarefoundation#6335) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…towarefoundation#6335) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To run intersection_occlusion by default, PR #6273 was shipped to handle intersection with traffic light smoothly. But it was missing the care for intersection without traffic light.
Related links
Tests performed
https://evaluation.tier4.jp/evaluation/reports/16a8370a-8fc2-5763-8dbe-3520492cef8c?project_id=prd_jt
without traffic light
with traffic light
initially, if no traffic light information is available, occlusion is ignored.
if traffic light information is available, occlusion is cared.
Notes for reviewers
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.