Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tier4_state_rviz_plugin): change service and topic name for engage #633

Merged
merged 1 commit into from
Apr 5, 2022

Conversation

rej55
Copy link
Contributor

@rej55 rej55 commented Apr 5, 2022

Signed-off-by: Fumiya Watanabe rej55.g@gmail.com

Description

I fixed the problem that /api/external/set/engage sent from autoware_state_panel is not received.
This problem occurs if the adapter from /api/external/set/engage to /api/autoware/set/engage is not launched.
To fix this problem, I changed the name of the service to /api/autoware/set/engage.

Please remark that using /api/external/set/engage is more desirable if the adapter is provided.
So, if the adapter is provided, we should replace the name of the service to /api/external/set/engage.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@rej55 rej55 requested review from h-ohta and isamu-takagi April 5, 2022 06:25
@rej55 rej55 force-pushed the fix/set_engage_service branch from 2d36bdf to 1e9fc8f Compare April 5, 2022 06:31
@rej55 rej55 changed the title fix(tier4_state_rviz_plugin):Change service/topic name for engage fix(tier4_state_rviz_plugin): Change service/topic name for engage Apr 5, 2022
@rej55 rej55 force-pushed the fix/set_engage_service branch from 1e9fc8f to b472f91 Compare April 5, 2022 06:33
@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Merging #633 (f895042) into main (5df2e38) will decrease coverage by 10.74%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #633       +/-   ##
==========================================
- Coverage   10.74%   0.00%   -10.75%     
==========================================
  Files         713       1      -712     
  Lines       50673     147    -50526     
  Branches     6572       0     -6572     
==========================================
- Hits         5445       0     -5445     
+ Misses      40821     147    -40674     
+ Partials     4407       0     -4407     
Impacted Files Coverage Δ
...er4_state_rviz_plugin/src/autoware_state_panel.cpp 0.00% <0.00%> (ø)
...dation/src/obstacle_pointcloud_based_validator.cpp
..._validation/src/occupancy_grid_based_validator.cpp
...bject_tracker/tracker/model/pedestrian_tracker.hpp
...ng_simulator/vehicle_model/sim_model_interface.hpp
...ehicle/raw_vehicle_cmd_converter/src/accel_map.cpp
...jectory_follower/longitudinal_controller_utils.hpp
...toware_auto_geometry/test/src/test_convex_hull.cpp
...ation_merger/data_association/data_association.cpp
...re_auto_geometry/include/geometry/spatial_hash.hpp
... and 703 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51f7a6b...f895042. Read the comment docs.

@rej55 rej55 changed the title fix(tier4_state_rviz_plugin): Change service/topic name for engage fix(tier4_state_rviz_plugin): Change service and topic name for engage Apr 5, 2022
@rej55 rej55 changed the title fix(tier4_state_rviz_plugin): Change service and topic name for engage fix(tier4_state_rviz_plugin): change service and topic name for engage Apr 5, 2022
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
@rej55 rej55 force-pushed the fix/set_engage_service branch from b472f91 to f895042 Compare April 5, 2022 06:38
@rej55 rej55 merged commit 15f43bc into autowarefoundation:main Apr 5, 2022
@rej55 rej55 deleted the fix/set_engage_service branch April 5, 2022 07:17
h-ohta referenced this pull request in tier4/autoware.universe Jun 13, 2022
h-ohta referenced this pull request in tier4/autoware.universe Jun 13, 2022
h-ohta added a commit that referenced this pull request Jun 13, 2022
* Revert "fix(autoware_state_panel): fix message type for /api/autoware/get/engage (#666)"

This reverts commit 49cc906.

* Revert "fix(tier4_state_rviz_plugin): change service and topic name for engage (#633)"

This reverts commit 15f43bc.
SoohyeokPark-MORAI pushed a commit to SoohyeokPark-MORAI/autoware.universe that referenced this pull request Jun 15, 2022
…ion#1079)

* Revert "fix(autoware_state_panel): fix message type for /api/autoware/get/engage (autowarefoundation#666)"

This reverts commit 49cc906.

* Revert "fix(tier4_state_rviz_plugin): change service and topic name for engage (autowarefoundation#633)"

This reverts commit 15f43bc.

Signed-off-by: SoohyeokPark-MORAI <shpark.morai@gmail.com>
SoohyeokPark-MORAI pushed a commit to SoohyeokPark-MORAI/autoware.universe that referenced this pull request Jun 15, 2022
…ion#1079)

* Revert "fix(autoware_state_panel): fix message type for /api/autoware/get/engage (autowarefoundation#666)"

This reverts commit 49cc906.

* Revert "fix(tier4_state_rviz_plugin): change service and topic name for engage (autowarefoundation#633)"

This reverts commit 15f43bc.
SoohyeokPark-MORAI pushed a commit to SoohyeokPark-MORAI/autoware.universe that referenced this pull request Jun 15, 2022
…ion#1079)

* Revert "fix(autoware_state_panel): fix message type for /api/autoware/get/engage (autowarefoundation#666)"

This reverts commit 49cc906.

* Revert "fix(tier4_state_rviz_plugin): change service and topic name for engage (autowarefoundation#633)"

This reverts commit 15f43bc.
0x126 referenced this pull request in tier4/autoware.universe Jun 22, 2022
* Revert "fix(autoware_state_panel): fix message type for /api/autoware/get/engage (#666)"

This reverts commit 49cc906.

* Revert "fix(tier4_state_rviz_plugin): change service and topic name for engage (#633)"

This reverts commit 15f43bc.
taikitanaka3 referenced this pull request in tier4/autoware.universe Jun 27, 2022
#633)

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
taikitanaka3 referenced this pull request in tier4/autoware.universe Jun 27, 2022
* Revert "fix(autoware_state_panel): fix message type for /api/autoware/get/engage (#666)"

This reverts commit 49cc906.

* Revert "fix(tier4_state_rviz_plugin): change service and topic name for engage (#633)"

This reverts commit 15f43bc.
boyali referenced this pull request in boyali/autoware.universe Jul 1, 2022
* Revert "fix(autoware_state_panel): fix message type for /api/autoware/get/engage (tier4#666)"

This reverts commit 49cc906.

* Revert "fix(tier4_state_rviz_plugin): change service and topic name for engage (tier4#633)"

This reverts commit 15f43bc.
yn-mrse referenced this pull request in tier4/autoware.universe Jul 27, 2022
* Revert "fix(autoware_state_panel): fix message type for /api/autoware/get/engage (#666)"

This reverts commit 49cc906.

* Revert "fix(tier4_state_rviz_plugin): change service and topic name for engage (#633)"

This reverts commit 15f43bc.
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
* Revert "fix(autoware_state_panel): fix message type for /api/autoware/get/engage (tier4#666)"

This reverts commit 49cc906.

* Revert "fix(tier4_state_rviz_plugin): change service and topic name for engage (tier4#633)"

This reverts commit 15f43bc.
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
* Revert "fix(autoware_state_panel): fix message type for /api/autoware/get/engage (tier4#666)"

This reverts commit 49cc906.

* Revert "fix(tier4_state_rviz_plugin): change service and topic name for engage (tier4#633)"

This reverts commit 15f43bc.
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
* Revert "fix(autoware_state_panel): fix message type for /api/autoware/get/engage (tier4#666)"

This reverts commit 49cc906.

* Revert "fix(tier4_state_rviz_plugin): change service and topic name for engage (tier4#633)"

This reverts commit 15f43bc.
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
* Revert "fix(autoware_state_panel): fix message type for /api/autoware/get/engage (tier4#666)"

This reverts commit 49cc906.

* Revert "fix(tier4_state_rviz_plugin): change service and topic name for engage (tier4#633)"

This reverts commit 15f43bc.
knzo25 pushed a commit to knzo25/autoware.universe that referenced this pull request Jul 3, 2023
kyoichi-sugahara pushed a commit that referenced this pull request Sep 16, 2023
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants