-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tier4_state_rviz_plugin): change service and topic name for engage #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rej55
force-pushed
the
fix/set_engage_service
branch
from
April 5, 2022 06:31
2d36bdf
to
1e9fc8f
Compare
rej55
changed the title
fix(tier4_state_rviz_plugin):Change service/topic name for engage
fix(tier4_state_rviz_plugin): Change service/topic name for engage
Apr 5, 2022
rej55
force-pushed
the
fix/set_engage_service
branch
from
April 5, 2022 06:33
1e9fc8f
to
b472f91
Compare
rej55
changed the title
fix(tier4_state_rviz_plugin): Change service/topic name for engage
fix(tier4_state_rviz_plugin): Change service and topic name for engage
Apr 5, 2022
rej55
changed the title
fix(tier4_state_rviz_plugin): Change service and topic name for engage
fix(tier4_state_rviz_plugin): change service and topic name for engage
Apr 5, 2022
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
rej55
force-pushed
the
fix/set_engage_service
branch
from
April 5, 2022 06:38
b472f91
to
f895042
Compare
isamu-takagi
approved these changes
Apr 5, 2022
This was referenced Apr 6, 2022
SoohyeokPark-MORAI
pushed a commit
to SoohyeokPark-MORAI/autoware.universe
that referenced
this pull request
Jun 15, 2022
…ion#1079) * Revert "fix(autoware_state_panel): fix message type for /api/autoware/get/engage (autowarefoundation#666)" This reverts commit 49cc906. * Revert "fix(tier4_state_rviz_plugin): change service and topic name for engage (autowarefoundation#633)" This reverts commit 15f43bc. Signed-off-by: SoohyeokPark-MORAI <shpark.morai@gmail.com>
SoohyeokPark-MORAI
pushed a commit
to SoohyeokPark-MORAI/autoware.universe
that referenced
this pull request
Jun 15, 2022
…ion#1079) * Revert "fix(autoware_state_panel): fix message type for /api/autoware/get/engage (autowarefoundation#666)" This reverts commit 49cc906. * Revert "fix(tier4_state_rviz_plugin): change service and topic name for engage (autowarefoundation#633)" This reverts commit 15f43bc.
SoohyeokPark-MORAI
pushed a commit
to SoohyeokPark-MORAI/autoware.universe
that referenced
this pull request
Jun 15, 2022
…ion#1079) * Revert "fix(autoware_state_panel): fix message type for /api/autoware/get/engage (autowarefoundation#666)" This reverts commit 49cc906. * Revert "fix(tier4_state_rviz_plugin): change service and topic name for engage (autowarefoundation#633)" This reverts commit 15f43bc.
taikitanaka3
referenced
this pull request
in tier4/autoware.universe
Jun 27, 2022
#633) Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
boyali
referenced
this pull request
in boyali/autoware.universe
Sep 28, 2022
tier4#633) Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
boyali
referenced
this pull request
in boyali/autoware.universe
Oct 3, 2022
tier4#633) Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
boyali
referenced
this pull request
in boyali/autoware.universe
Oct 3, 2022
tier4#633) Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
boyali
referenced
this pull request
in boyali/autoware.universe
Oct 19, 2022
tier4#633) Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
knzo25
pushed a commit
to knzo25/autoware.universe
that referenced
this pull request
Jul 3, 2023
chore: sync upstream
kyoichi-sugahara
pushed a commit
that referenced
this pull request
Sep 16, 2023
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Fumiya Watanabe rej55.g@gmail.com
Description
I fixed the problem that
/api/external/set/engage
sent fromautoware_state_panel
is not received.This problem occurs if the adapter from
/api/external/set/engage
to/api/autoware/set/engage
is not launched.To fix this problem, I changed the name of the service to
/api/autoware/set/engage
.Please remark that using
/api/external/set/engage
is more desirable if the adapter is provided.So, if the adapter is provided, we should replace the name of the service to
/api/external/set/engage
.Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.