Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(start_planner): add start/end condition #6329

Merged
merged 32 commits into from
Feb 6, 2024
Merged

docs(start_planner): add start/end condition #6329

merged 32 commits into from
Feb 6, 2024

Conversation

kyoichi-sugahara
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara commented Feb 6, 2024 •
edited
Loading

Description

update README for start_planner
This PR mainly includes description of start/end condition of module

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

kyoichi-sugahara and others added 18 commits February 1, 2024 14:32
@kyoichi-sugahara
Add start planner module and related images
4896d0b 
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@kyoichi-sugahara
delete images
edef4bf 
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@pre-commit-ci @kyoichi-sugahara
style(pre-commit): autofix
edfe188
@kyoichi-sugahara
Update geometric pull out path generation in shoulder lane
6d7b08e 
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@kyoichi-sugahara
Update README.md with additional path generation feature
8b17319 
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@pre-commit-ci @kyoichi-sugahara
style(pre-commit): autofix
d6015bf
@kyoichi-sugahara
temp
7849ced 
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@kyoichi-sugahara
fix
098dacf 
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@kyoichi-sugahara
fix
a834cac 
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@kyoichi-sugahara
Update README.md with path generation examples
5efe618 
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@kyoichi-sugahara
add image
c97858c 
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@kyoichi-sugahara
Merge branch 'main' into docs/start_planner_safety_concept
7fd1a72 
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@kyoichi-sugahara
add Start Condition section
e23b116 
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@kyoichi-sugahara
add module end condition
61ec2ff 
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@kyoichi-sugahara
add Manual and auto mode behaviors
3d7a739 
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@kyoichi-sugahara
add safety check range
6e24327 
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@kyoichi-sugahara
Merge branch 'main' into docs/start_planner_flow
8b27251
@kyoichi-sugahara
search start pose
5c8d911 
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Feb 6, 2024
@kyoichi-sugahara kyoichi-sugahara added the run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) label Feb 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2024

Documentation URL: https://autowarefoundation.github.io/autoware.universe/pr-6329/
Modified URLs:

pre-commit-ci bot and others added 8 commits February 6, 2024 03:49
@pre-commit-ci
style(pre-commit): autofix
21a1ae6
@kyoichi-sugahara
update
e15f9db 
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@kyoichi-sugahara
Merge branch 'main' into docs/start_planner_flow
8c2586f 
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@kyoichi-sugahara
update image
ce0fe9d 
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@pre-commit-ci
style(pre-commit): autofix
df46f8a
@kyoichi-sugahara
fix rtc interface
e255ad9 
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@kyoichi-sugahara
change order
481c196 
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@kyoichi-sugahara
update
56a144d 
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
kyoichi-sugahara and others added 2 commits February 6, 2024 20:37
@kyoichi-sugahara
update image
721e0a0 
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@pre-commit-ci
style(pre-commit): autofix
66ba925
@kyoichi-sugahara kyoichi-sugahara changed the title docs(start_planner): update README docs(start_planner): add start/end condition Feb 6, 2024
@kyoichi-sugahara
fix error
fe34b6b 
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@kyoichi-sugahara
update
51fb124 
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@kyoichi-sugahara kyoichi-sugahara marked this pull request as ready for review February 6, 2024 11:49
@kyoichi-sugahara
change route to path
3b87e23 
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@kyoichi-sugahara
change obstacle_stop_planer to obstacle_cruise_planner
1d52778 
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
kosuke55
kosuke55 approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@kyoichi-sugahara kyoichi-sugahara added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 6, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d408e15) 14.86% compared to head (1d52778) 14.81%.
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6329      +/-   ##
==========================================
- Coverage   14.86%   14.81%   -0.05%     
==========================================
  Files        1845     1845              
  Lines      126586   126994     +408     
  Branches    37871    37871              
==========================================
  Hits        18820    18820              
- Misses      86608    87016     +408     
  Partials    21158    21158
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 14.86% <ø> (ø) Carriedforward from d408e15

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kyoichi-sugahara kyoichi-sugahara merged commit e2bd68f into autowarefoundation:main Feb 6, 2024
34 of 36 checks passed
@kyoichi-sugahara kyoichi-sugahara deleted the docs/start_planner_flow branch February 6, 2024 14:58
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Feb 7, 2024
Merged
anhnv3991 pushed a commit to anhnv3991/autoware.universe that referenced this pull request Feb 13, 2024
@kyoichi-sugahara @anhnv3991
docs(start_planner): add start/end condition (autowarefoundation#6329)
3c86783 
add start/end condition

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

---------

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
StepTurtle pushed a commit to StepTurtle/autoware.universe that referenced this pull request Feb 28, 2024
@kyoichi-sugahara @StepTurtle
docs(start_planner): add start/end condition (autowarefoundation#6329)
4d26dc5 
add start/end condition

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

---------

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
@kyoichi-sugahara @karishma1911
docs(start_planner): add start/end condition (autowarefoundation#6329)
7a44860 
add start/end condition

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

---------

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kosuke55 kosuke55 kosuke55 approved these changes

@danielsanchezaran danielsanchezaran Awaiting requested review from danielsanchezaran

@soblin soblin Awaiting requested review from soblin

@satoshi-ota satoshi-ota Awaiting requested review from satoshi-ota

@shmpwk shmpwk Awaiting requested review from shmpwk

@TomohitoAndo TomohitoAndo Awaiting requested review from TomohitoAndo

@tkimura4 tkimura4 Awaiting requested review from tkimura4

Assignees
No one assigned
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kyoichi-sugahara @kosuke55