revert(map_loader): revert the change error handling when pcd_metadata file #6294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not found (autowarefoundation#6227)" This reverts commit 25bc636.
SakodaShintaro
requested review from
anhnv3991,
KYabuuchi,
kminoda,
Motsu-san,
mitsudome-r,
RyuYamamoto,
TaikiYamada4 and
YamatoAndo
as code owners
github-actions
bot
added
the
component:map
SakodaShintaro
changed the title
KYabuuchi
approved these changes
Feb 2, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6294 +/- ##
=======================================
Coverage 14.37% 14.37%
=======================================
Files 1907 1907
Lines 130072 130070 -2
Branches 37618 37616 -2
=======================================
Hits 18697 18697
+ Misses 90366 90364 -2
Partials 21009 21009
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SakodaShintaro
merged commit e063f2d
into
autowarefoundation:main
22 of 24 checks passed
4 tasks
anhnv3991
pushed a commit
to anhnv3991/autoware.universe
that referenced
this pull request
Feb 13, 2024
…a file (autowarefoundation#6294) Revert "fix(map_loader): change error handling when pcd_metadata file not found (autowarefoundation#6227)" This reverts commit 25bc636.
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…a file (autowarefoundation#6294) Revert "fix(map_loader): change error handling when pcd_metadata file not found (autowarefoundation#6227)" This reverts commit 25bc636.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This reverts commit #6227 (25bc636).
After the pull request above, if "divided map is used and pointcloud_map_metadata.yaml is missing", initial_pose_adaptor does not work properly and there is unexpected side effects in planning_simulator, so we decide to revert.
Tests performed
pointcloud_map_metadata.yamlis present (in AWSIM).pointcloud_map_metadata.yamlis missing (in AWSIM).Effects on system behavior
The error message will change.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.