Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tensorrt_common): revert change that breaks build on Jetson Orin #6274

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

bgilby59
Copy link
Contributor

@bgilby59 bgilby59 commented Feb 1, 2024

Description

This pull request partially reverts #6117 so that tensorrt_common can be built on Jetson Orin.

Tests performed

tensorrt_common was built on a Jetson Orin ECU.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Feb 1, 2024
@bgilby59 bgilby59 requested a review from ktro2828 February 1, 2024 05:19
@bgilby59
Copy link
Contributor Author

bgilby59 commented Feb 1, 2024

It looks like I need to fix an issue with signing off commits really quickly.

Signed-off-by: Benjamin Gilby <gilbybenjamin@gmail.com>
@bgilby59
Copy link
Contributor Author

bgilby59 commented Feb 1, 2024

This PR is ready for a review now @ktro2828

@manato
Copy link
Contributor

manato commented Feb 1, 2024

@bgilby59
Thank you for your commitment.
I guess this modification is to make the building succeed in a specific environment (gcc version or TensorRT version).
For future reference to ones who will google a solution against similar issues, could you briefly note the version of the environment (or condition) that requires this modification?

@bgilby59
Copy link
Contributor Author

bgilby59 commented Feb 1, 2024

@manato
The environment was Jetson Orin, Jetpack 5.1.1, Ubuntu 20.04.

In particular, before this PR's change, building tensorrt_common failed for GCC version < 11 (versions 8.4.0, 9.4.0, and 10.5.0 were all tested and failed)

Copy link
Contributor

@manato manato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for answering my question. LGTM

@ktro2828 ktro2828 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 1, 2024
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (55c52af) 14.38% compared to head (6410a2b) 14.38%.
Report is 15 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6274   +/-   ##
=======================================
  Coverage   14.38%   14.38%           
=======================================
  Files        1906     1906           
  Lines      129910   129910           
  Branches    37616    37616           
=======================================
  Hits        18691    18691           
  Misses      90207    90207           
  Partials    21012    21012           
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 14.38% <ø> (ø) Carriedforward from 55c52af

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bgilby59 bgilby59 merged commit fa8424d into autowarefoundation:main Feb 2, 2024
31 of 32 checks passed
anhnv3991 pushed a commit to anhnv3991/autoware.universe that referenced this pull request Feb 13, 2024
…utowarefoundation#6274)

fix: remove breaking change

Signed-off-by: Benjamin Gilby <gilbybenjamin@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…utowarefoundation#6274)

fix: remove breaking change

Signed-off-by: Benjamin Gilby <gilbybenjamin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants