-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tensorrt_common): revert change that breaks build on Jetson Orin #6274
Conversation
It looks like I need to fix an issue with signing off commits really quickly. |
Signed-off-by: Benjamin Gilby <gilbybenjamin@gmail.com>
ced8959
to
6410a2b
Compare
This PR is ready for a review now @ktro2828 |
@bgilby59 |
@manato In particular, before this PR's change, building tensorrt_common failed for GCC version < 11 (versions 8.4.0, 9.4.0, and 10.5.0 were all tested and failed) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for answering my question. LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6274 +/- ##
=======================================
Coverage 14.38% 14.38%
=======================================
Files 1906 1906
Lines 129910 129910
Branches 37616 37616
=======================================
Hits 18691 18691
Misses 90207 90207
Partials 21012 21012
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…utowarefoundation#6274) fix: remove breaking change Signed-off-by: Benjamin Gilby <gilbybenjamin@gmail.com>
…utowarefoundation#6274) fix: remove breaking change Signed-off-by: Benjamin Gilby <gilbybenjamin@gmail.com>
Description
This pull request partially reverts #6117 so that tensorrt_common can be built on Jetson Orin.
Tests performed
tensorrt_common was built on a Jetson Orin ECU.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.