-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(intersection): memorize last observed valid traffic light information #6272
Merged
soblin
merged 1 commit into
autowarefoundation:main
from
tier4:feat/intersection/memoize-last-observation
Feb 2, 2024
Merged
feat(intersection): memorize last observed valid traffic light information #6272
soblin
merged 1 commit into
autowarefoundation:main
from
tier4:feat/intersection/memoize-last-observation
Feb 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
label
Feb 1, 2024
7 tasks
soblin
force-pushed
the
feat/intersection/memoize-last-observation
branch
2 times, most recently
from
February 2, 2024 03:52
8daf8d3
to
4257f3f
Compare
…ation Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
soblin
force-pushed
the
feat/intersection/memoize-last-observation
branch
from
February 2, 2024 09:04
4257f3f
to
9deeae0
Compare
soblin
requested review from
kyoichi-sugahara,
shmpwk,
takayuki5168 and
tkimura4
as code owners
February 2, 2024 09:36
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6272 +/- ##
==========================================
- Coverage 14.38% 14.38% -0.01%
==========================================
Files 1907 1907
Lines 129943 129999 +56
Branches 37616 37656 +40
==========================================
Hits 18695 18695
- Misses 90238 90290 +52
- Partials 21010 21014 +4
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
takayuki5168
approved these changes
Feb 2, 2024
7 tasks
soblin
added a commit
to tier4/autoware.universe
that referenced
this pull request
Feb 6, 2024
…ation (autowarefoundation#6272) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
soblin
added a commit
to tier4/autoware.universe
that referenced
this pull request
Feb 6, 2024
feat(intersection): cherry pick intersection (autowarefoundation#6047 + autowarefoundation#6134+ autowarefoundation#6143 + autowarefoundation#6201 + autowarefoundation#6207 + autowarefoundation#6272 + autowarefoundation#6315)
anhnv3991
pushed a commit
to anhnv3991/autoware.universe
that referenced
this pull request
Feb 13, 2024
…ation (autowarefoundation#6272) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…ation (autowarefoundation#6272) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
intersection module keeps the last observed information of traffic light if the info got unavailable. Also I added a marker indicating which color is used inside the intersection module.
Related links
Tests performed
Initially "RED" info is available on the topic. at [00:21] and [00:25] and [00:40] "GREEN" / "YELLOW" / "RED" info is available. from [00:44] to [01:27] the info for "10277" is unavailable, but intersection module keeps the "RED" information. Then it receives "GREEN" infor again.
PR6272-2024-02-02_18.05.45.mp4
Notes for reviewers
Interface changes
none
Effects on system behavior
if a specific traffic signal information is removed from prior iteration (mainly due to out-of-range camera / out-of-range V2I), intersection module will keep using prior signal information, not "UNKNOWN"
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.