Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(intersection): memorize last observed valid traffic light information #6272

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Feb 1, 2024

Description

intersection module keeps the last observed information of traffic light if the info got unavailable. Also I added a marker indicating which color is used inside the intersection module.

Related links

Tests performed

Initially "RED" info is available on the topic. at [00:21] and [00:25] and [00:40] "GREEN" / "YELLOW" / "RED" info is available. from [00:44] to [01:27] the info for "10277" is unavailable, but intersection module keeps the "RED" information. Then it receives "GREEN" infor again.

PR6272-2024-02-02_18.05.45.mp4

Notes for reviewers

Interface changes

none

Effects on system behavior

if a specific traffic signal information is removed from prior iteration (mainly due to out-of-range camera / out-of-range V2I), intersection module will keep using prior signal information, not "UNKNOWN"

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Feb 1, 2024
@soblin soblin force-pushed the feat/intersection/memoize-last-observation branch 2 times, most recently from 8daf8d3 to 4257f3f Compare February 2, 2024 03:52
…ation

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@soblin soblin force-pushed the feat/intersection/memoize-last-observation branch from 4257f3f to 9deeae0 Compare February 2, 2024 09:04
@soblin soblin marked this pull request as ready for review February 2, 2024 09:36
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: 65 lines in your changes are missing coverage. Please review.

Comparison is base (cc266ea) 14.38% compared to head (9deeae0) 14.38%.
Report is 12 commits behind head on main.

Files Patch % Lines
...ity_intersection_module/src/scene_intersection.cpp 0.00% 30 Missing ⚠️
...ehavior_velocity_intersection_module/src/debug.cpp 0.00% 24 Missing ⚠️
...ion_module/src/scene_intersection_prepare_data.cpp 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6272      +/-   ##
==========================================
- Coverage   14.38%   14.38%   -0.01%     
==========================================
  Files        1907     1907              
  Lines      129943   129999      +56     
  Branches    37616    37656      +40     
==========================================
  Hits        18695    18695              
- Misses      90238    90290      +52     
- Partials    21010    21014       +4     
Flag Coverage Δ *Carryforward flag
differential 4.63% <0.00%> (?)
total 14.39% <ø> (+<0.01%) ⬆️ Carriedforward from cc266ea

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soblin soblin merged commit 2b1a33f into autowarefoundation:main Feb 2, 2024
22 of 26 checks passed
@soblin soblin deleted the feat/intersection/memoize-last-observation branch February 2, 2024 10:24
soblin added a commit to tier4/autoware.universe that referenced this pull request Feb 6, 2024
…ation (autowarefoundation#6272)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
anhnv3991 pushed a commit to anhnv3991/autoware.universe that referenced this pull request Feb 13, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants