New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(radar_crossing_noise_filter): add unit test #6257

Merged

scepter914 merged 8 commits into autowarefoundation:main from N-Eiki:feat/radar_crossing_noise_filter

Feb 26, 2024

+210 −0

Merged

feat(radar_crossing_noise_filter): add unit test #6257

Merge branch 'main' into feat/radar_crossing_noise_filter

CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Feb 26, 2024 in 39s

CodeScene PR Check

✅ Code Health Quality Gates: OK

Declining Code Health: 1 findings(s) 🚩
Improving Code Health: 0 findings(s) ✅
Affected Hotspots: 0 files(s) 🔥

Recommended Review Level: Lightweight sanity check
View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

Large Method test_radar_crossing_objects_filter_is_noise.cpp: TEST:RadarCrossingObjectsFilter:IsNoise

Annotations

Check warning on line 175 in perception/radar_crossing_objects_noise_filter/test/test_radar_crossing_objects_noise_filter/test_radar_crossing_objects_filter_is_noise.cpp

codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Large Method

TEST:RadarCrossingObjectsFilter:IsNoise has 124 lines, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.

View more details on CodeScene Delta Analysis