-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(yabloc): replace parameters by json_to_markdown in readme #6183
Merged
KYabuuchi
merged 3 commits into
autowarefoundation:main
from
KYabuuchi:chore/re_rework_parameters
Jan 26, 2024
Merged
chore(yabloc): replace parameters by json_to_markdown in readme #6183
KYabuuchi
merged 3 commits into
autowarefoundation:main
from
KYabuuchi:chore/re_rework_parameters
Jan 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
github-actions
bot
added
type:documentation
Creating or refining documentation. (auto-assigned)
component:localization
Vehicle's position determination in its environment. (auto-assigned)
labels
Jan 26, 2024
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
KYabuuchi
requested review from
Motsu-san,
RyuYamamoto,
SakodaShintaro,
TaikiYamada4 and
YamatoAndo
as code owners
January 26, 2024 05:21
YamatoAndo
approved these changes
Jan 26, 2024
KYabuuchi
added
the
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Jan 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6183 +/- ##
=======================================
Coverage 14.58% 14.58%
=======================================
Files 1871 1871
Lines 127545 127545
Branches 37311 37311
=======================================
Hits 18606 18606
Misses 88019 88019
Partials 20920 20920
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
anhnv3991
pushed a commit
to anhnv3991/autoware.universe
that referenced
this pull request
Jan 29, 2024
…warefoundation#6183) * replace parameters by json_to_markdown Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * fix some schma path Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * fix again Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> --------- Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> Signed-off-by: anhnv3991 <anh.nguyen.2@tier4.jp>
kyoichi-sugahara
pushed a commit
to kyoichi-sugahara/autoware.universe
that referenced
this pull request
Jan 29, 2024
…warefoundation#6183) * replace parameters by json_to_markdown Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * fix some schma path Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * fix again Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> --------- Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…warefoundation#6183) * replace parameters by json_to_markdown Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * fix some schma path Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * fix again Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> --------- Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:localization
Vehicle's position determination in its environment. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
type:documentation
Creating or refining documentation. (auto-assigned)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed parameter visualizations that were not updated in #6170
Tests performed
With the following, I confirmed that there are 10 json.schema under
localization/yabloc/
.Then, I confirmed that
json_to_markdown
appears 10 times with corresponding schema.json pathes.Finally, I confirmed with mkdocs
Effects on system behavior
Does not affect.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.