-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tracking_object_merger): enable to association unknown class in tracker merger #6182
fix(tracking_object_merger): enable to association unknown class in tracker merger #6182
Conversation
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6182 +/- ##
=======================================
Coverage 14.63% 14.63%
=======================================
Files 1858 1858
Lines 126848 126848
Branches 37173 37173
=======================================
Hits 18570 18570
Misses 87390 87390
Partials 20888 20888
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…racker merger (autowarefoundation#6182) * fix: enable to association unknown class in tracker merger Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * chore: disable warning messages caused by unknown association Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> --------- Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
…racker merger (autowarefoundation#6182) * fix: enable to association unknown class in tracker merger Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * chore: disable warning messages caused by unknown association Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> --------- Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
…racker merger (autowarefoundation#6182) * fix: enable to association unknown class in tracker merger Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * chore: disable warning messages caused by unknown association Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> --------- Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
…racker merger autowarefoundation#6182 (#1123) fix(tracking_object_merger): enable to association unknown class in tracker merger (autowarefoundation#6182) * fix: enable to association unknown class in tracker merger * chore: disable warning messages caused by unknown association --------- Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> Co-authored-by: Yoshi Ri <yoshiyoshidetteiu@gmail.com>
…racker merger (autowarefoundation#6182) * fix: enable to association unknown class in tracker merger Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * chore: disable warning messages caused by unknown association Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> --------- Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Description
This PR fixes wrong association settings for tracking object merger.
Tests performed
Effects on system behavior
Less unknown objects will appear
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.