Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tracking_object_merger): enable to association unknown class in tracker merger #6182

Conversation

YoshiRi
Copy link
Contributor

@YoshiRi YoshiRi commented Jan 26, 2024

Description

This PR fixes wrong association settings for tracking object merger.

  • before: unknown class was not associated each other
  • after: unknown objects will associated each other

Tests performed

Effects on system behavior

Less unknown objects will appear

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
@YoshiRi YoshiRi requested a review from yukkysaito as a code owner January 26, 2024 03:12
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Jan 26, 2024
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YoshiRi YoshiRi added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 26, 2024
@YoshiRi YoshiRi enabled auto-merge (squash) January 26, 2024 03:51
@YoshiRi YoshiRi disabled auto-merge January 26, 2024 08:34
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Copy link

codecov bot commented Jan 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a3f90f0) 14.63% compared to head (9435df4) 14.63%.
Report is 77 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6182   +/-   ##
=======================================
  Coverage   14.63%   14.63%           
=======================================
  Files        1858     1858           
  Lines      126848   126848           
  Branches    37173    37173           
=======================================
  Hits        18570    18570           
  Misses      87390    87390           
  Partials    20888    20888           
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 14.63% <ø> (ø) Carriedforward from a3f90f0

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@YoshiRi YoshiRi merged commit f9ed5b0 into autowarefoundation:main Jan 29, 2024
22 of 25 checks passed
@YoshiRi YoshiRi deleted the fix/tracking_object_merger_association_fix branch January 29, 2024 06:06
shmpwk pushed a commit to tier4/autoware.universe that referenced this pull request Jan 29, 2024
…racker merger (autowarefoundation#6182)

* fix: enable to association unknown class in tracker merger

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* chore: disable warning messages caused by unknown association

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

---------

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Jan 29, 2024
…racker merger (autowarefoundation#6182)

* fix: enable to association unknown class in tracker merger

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* chore: disable warning messages caused by unknown association

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

---------

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
@kminoda
Copy link
Contributor

kminoda commented Jan 31, 2024

FYI: TIER IV INTERNAL TICKER

0x126 pushed a commit to tier4/autoware.universe that referenced this pull request Jan 31, 2024
…racker merger (autowarefoundation#6182)

* fix: enable to association unknown class in tracker merger

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* chore: disable warning messages caused by unknown association

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

---------

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
0x126 added a commit to tier4/autoware.universe that referenced this pull request Feb 2, 2024
…racker merger autowarefoundation#6182 (#1123)

fix(tracking_object_merger): enable to association unknown class in tracker merger (autowarefoundation#6182)

* fix: enable to association unknown class in tracker merger



* chore: disable warning messages caused by unknown association



---------

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Co-authored-by: Yoshi Ri <yoshiyoshidetteiu@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…racker merger (autowarefoundation#6182)

* fix: enable to association unknown class in tracker merger

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* chore: disable warning messages caused by unknown association

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

---------

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants