-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(lane_change): combine all debug data into single struct #6173
Merged
zulfaqar-azmi-t4
merged 4 commits into
autowarefoundation:main
from
zulfaqar-azmi-t4:refactor-lane-change-debug-marker
Jan 29, 2024
Merged
refactor(lane_change): combine all debug data into single struct #6173
zulfaqar-azmi-t4
merged 4 commits into
autowarefoundation:main
from
zulfaqar-azmi-t4:refactor-lane-change-debug-marker
Jan 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
zulfaqar-azmi-t4
requested review from
rej55,
kosuke55,
shmpwk,
TomohitoAndo and
tkimura4
as code owners
January 25, 2024 06:21
github-actions
bot
added
the
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
label
Jan 25, 2024
zulfaqar-azmi-t4
added
the
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Jan 25, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6173 +/- ##
==========================================
- Coverage 14.58% 14.58% -0.01%
==========================================
Files 1871 1872 +1
Lines 127546 127558 +12
Branches 37310 37310
==========================================
+ Hits 18606 18607 +1
- Misses 88020 88031 +11
Partials 20920 20920
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
rej55
approved these changes
Jan 29, 2024
zulfaqar-azmi-t4
merged commit Jan 29, 2024
6d8f026
into
autowarefoundation:main
20 of 24 checks passed
kyoichi-sugahara
pushed a commit
to kyoichi-sugahara/autoware.universe
that referenced
this pull request
Jan 29, 2024
…owarefoundation#6173) * refactor(lane_change): combine all debug data into single struct Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Rename valid path → valid paths Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * move the marker creation to marker_utils Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Remove alias Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> --------- Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
zulfaqar-azmi-t4
added a commit
to tier4/autoware.universe
that referenced
this pull request
Feb 22, 2024
…owarefoundation#6173) * refactor(lane_change): combine all debug data into single struct Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Rename valid path → valid paths Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * move the marker creation to marker_utils Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Remove alias Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> --------- Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
satoshi-ota
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Feb 23, 2024
…owarefoundation#6173) * refactor(lane_change): combine all debug data into single struct Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Rename valid path → valid paths Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * move the marker creation to marker_utils Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Remove alias Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> --------- Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
satoshi-ota
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Feb 23, 2024
…owarefoundation#6173) * refactor(lane_change): combine all debug data into single struct Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Rename valid path → valid paths Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * move the marker creation to marker_utils Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Remove alias Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> --------- Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
zulfaqar-azmi-t4
added a commit
to tier4/autoware.universe
that referenced
this pull request
Mar 7, 2024
…owarefoundation#6173) * refactor(lane_change): combine all debug data into single struct Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Rename valid path → valid paths Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * move the marker creation to marker_utils Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Remove alias Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> --------- Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…owarefoundation#6173) * refactor(lane_change): combine all debug data into single struct Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Rename valid path → valid paths Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * move the marker creation to marker_utils Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Remove alias Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> --------- Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Combine all debug data in lane change into single struct.
This is so that if new debug info is added, we dont need to update the
base_class.hpp
Related links
None
Tests performed
Tested via PSIM.
Notes for reviewers
None
Interface changes
None
Effects on system behavior
None
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.