Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(lane_change): combine all debug data into single struct #6173

Conversation

zulfaqar-azmi-t4
Copy link
Contributor

Description

Combine all debug data in lane change into single struct.
This is so that if new debug info is added, we dont need to update the base_class.hpp

Related links

None

Tests performed

Tested via PSIM.

PSIM test

image

Notes for reviewers

None

Interface changes

None

Effects on system behavior

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 25, 2024
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 25, 2024
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 42 lines in your changes are missing coverage. Please review.

Comparison is base (2719ad4) 14.58% compared to head (07fa99d) 14.58%.
Report is 12 commits behind head on main.

Files Patch % Lines
...vior_path_lane_change_module/src/utils/markers.cpp 0.00% 20 Missing ⚠️
...ing/behavior_path_lane_change_module/src/scene.cpp 0.00% 13 Missing ⚠️
...or_path_lane_change_module/utils/debug_structs.hpp 0.00% 3 Missing and 1 partial ⚠️
...behavior_path_lane_change_module/src/interface.cpp 33.33% 4 Missing ⚠️
...avior_path_lane_change_module/utils/base_class.hpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6173      +/-   ##
==========================================
- Coverage   14.58%   14.58%   -0.01%     
==========================================
  Files        1871     1872       +1     
  Lines      127546   127558      +12     
  Branches    37310    37310              
==========================================
+ Hits        18606    18607       +1     
- Misses      88020    88031      +11     
  Partials    20920    20920              
Flag Coverage Δ *Carryforward flag
differential 9.20% <4.54%> (?)
total 14.58% <ø> (+<0.01%) ⬆️ Carriedforward from 18bf8dd

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 merged commit 6d8f026 into autowarefoundation:main Jan 29, 2024
20 of 24 checks passed
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Jan 29, 2024
…owarefoundation#6173)

* refactor(lane_change): combine all debug data into single struct

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* Rename valid path → valid paths

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* move the marker creation to marker_utils

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* Remove alias

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

---------

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
zulfaqar-azmi-t4 added a commit to tier4/autoware.universe that referenced this pull request Feb 22, 2024
…owarefoundation#6173)

* refactor(lane_change): combine all debug data into single struct

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* Rename valid path → valid paths

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* move the marker creation to marker_utils

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* Remove alias

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

---------

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
satoshi-ota pushed a commit to tier4/autoware.universe that referenced this pull request Feb 23, 2024
…owarefoundation#6173)

* refactor(lane_change): combine all debug data into single struct

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* Rename valid path → valid paths

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* move the marker creation to marker_utils

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* Remove alias

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

---------

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
satoshi-ota pushed a commit to tier4/autoware.universe that referenced this pull request Feb 23, 2024
…owarefoundation#6173)

* refactor(lane_change): combine all debug data into single struct

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* Rename valid path → valid paths

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* move the marker creation to marker_utils

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* Remove alias

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

---------

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
zulfaqar-azmi-t4 added a commit to tier4/autoware.universe that referenced this pull request Mar 7, 2024
…owarefoundation#6173)

* refactor(lane_change): combine all debug data into single struct

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* Rename valid path → valid paths

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* move the marker creation to marker_utils

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* Remove alias

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

---------

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…owarefoundation#6173)

* refactor(lane_change): combine all debug data into single struct

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* Rename valid path → valid paths

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* move the marker creation to marker_utils

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* Remove alias

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

---------

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 deleted the refactor-lane-change-debug-marker branch June 18, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants