Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(detected_object_validation): rework parameters #6166

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Jan 25, 2024

Description

Use parameter file

Tests performed

Launch each nodes individually and confirmed that they load parameters as expected

Effects on system behavior

No effect expected

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kminoda <koji.minoda@tier4.jp>
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Jan 25, 2024
@kminoda kminoda changed the title chore(detected_object_validation): use config chore(detected_object_validation): rework parameters Jan 25, 2024
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kminoda kminoda added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 26, 2024
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2719ad4) 14.58% compared to head (2f95741) 14.58%.
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6166   +/-   ##
=======================================
  Coverage   14.58%   14.58%           
=======================================
  Files        1871     1871           
  Lines      127546   127546           
  Branches    37310    37310           
=======================================
  Hits        18606    18606           
  Misses      88020    88020           
  Partials    20920    20920           
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 14.58% <ø> (ø) Carriedforward from 2719ad4

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kminoda kminoda merged commit db637bb into autowarefoundation:main Jan 29, 2024
34 of 36 checks passed
anhnv3991 pushed a commit to anhnv3991/autoware.universe that referenced this pull request Jan 29, 2024
…ion#6166)

chore(detected_object_validation): use config

Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: anhnv3991 <anh.nguyen.2@tier4.jp>
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Jan 29, 2024
…ion#6166)

chore(detected_object_validation): use config

Signed-off-by: kminoda <koji.minoda@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…ion#6166)

chore(detected_object_validation): use config

Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda kminoda deleted the chore/detected_object_validation/use_config branch June 20, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants