fix(simple_object_merger): change the default param of timeout_threshold #6133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: scepter914 <scepter914@gmail.com>
github-actions
bot
added
type:documentation
scepter914
added
the
run:build-and-test-differential
Signed-off-by: scepter914 <scepter914@gmail.com>
github-actions
bot
removed
the
type:documentation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6133 +/- ##
=======================================
Coverage 14.58% 14.58%
=======================================
Files 1871 1871
Lines 127545 127543 -2
Branches 37311 37311
=======================================
Hits 18606 18606
+ Misses 88019 88017 -2
Partials 20920 20920
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
YoshiRi
approved these changes
Jan 29, 2024
kyoichi-sugahara
pushed a commit
to kyoichi-sugahara/autoware.universe
that referenced
this pull request
Jan 29, 2024
…old (autowarefoundation#6133) * fix(simple_object_merger): change the default param of timeout_threshold Signed-off-by: scepter914 <scepter914@gmail.com> * fix conflict Signed-off-by: scepter914 <scepter914@gmail.com> --------- Signed-off-by: scepter914 <scepter914@gmail.com>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…old (autowarefoundation#6133) * fix(simple_object_merger): change the default param of timeout_threshold Signed-off-by: scepter914 <scepter914@gmail.com> * fix conflict Signed-off-by: scepter914 <scepter914@gmail.com> --------- Signed-off-by: scepter914 <scepter914@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR change the default param of timeout_threshold.
The default timeout value should be based on LiDAR cycle 100ms, and 1.0s is so long.
So this PR change the default param of timeout_threshold from 1.0 into 0.1.
Tests performed
Only build test.
Effects on system behavior
No effect.
https://github.com/tier4/aip_launcher/blob/tier4/universe/aip_x2_launch/launch/radar.launch.xml#L66 set the parameter and don't use the default parameter.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.