Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(intersection): distinguish 1st/2nd attention lanelet #6042

Merged

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Jan 10, 2024

Description

obtain second_attention_lanelet as well as first_attention_lanelet

Related links

Tests performed

evaluator: https://evaluation.tier4.jp/evaluation/reports/f101b282-365a-5a42-bc3d-eaf7681328ce?project_id=prd_jt

If the intersection is single lane, second_attention_lane is null.

image

image

image

image

Notes for reviewers

Interface changes

none.

Effects on system behavior

none.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 10, 2024
@soblin soblin force-pushed the feat/intersection/second-attention-lane branch from 6bcc5b4 to 23faeed Compare January 10, 2024 08:17
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@soblin soblin force-pushed the feat/intersection/second-attention-lane branch from 23faeed to 94f27ea Compare January 10, 2024 08:20
@soblin soblin marked this pull request as ready for review January 10, 2024 08:22
@soblin soblin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 10, 2024
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@soblin soblin enabled auto-merge (squash) January 10, 2024 15:38
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 58 lines in your changes are missing coverage. Please review.

Comparison is base (2a6c16b) 15.22% compared to head (94f27ea) 15.22%.
Report is 9 commits behind head on main.

Files Patch % Lines
...ity_intersection_module/src/scene_intersection.cpp 0.00% 49 Missing ⚠️
...ehavior_velocity_intersection_module/src/debug.cpp 0.00% 8 Missing ⚠️
...ity_intersection_module/src/scene_intersection.hpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6042      +/-   ##
==========================================
- Coverage   15.22%   15.22%   -0.01%     
==========================================
  Files        1767     1767              
  Lines      121695   121741      +46     
  Branches    37020    37047      +27     
==========================================
  Hits        18534    18534              
- Misses      82349    82394      +45     
- Partials    20812    20813       +1     
Flag Coverage Δ *Carryforward flag
differential 5.21% <0.00%> (?)
total 15.23% <ø> (+<0.01%) ⬆️ Carriedforward from 2a6c16b

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soblin soblin merged commit 28c871a into autowarefoundation:main Jan 10, 2024
31 of 35 checks passed
@soblin soblin deleted the feat/intersection/second-attention-lane branch January 10, 2024 19:56
soblin added a commit to tier4/autoware.universe that referenced this pull request Jan 11, 2024
…n#6048 + migration for beta/v0.43.6

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
zulfaqar-azmi-t4 pushed a commit to zulfaqar-azmi-t4/autoware.universe that referenced this pull request Jan 11, 2024
soblin added a commit to tier4/autoware.universe that referenced this pull request Jan 12, 2024
soblin added a commit to tier4/autoware.universe that referenced this pull request Jan 12, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
soblin added a commit to tier4/autoware.universe that referenced this pull request Oct 23, 2024
soblin added a commit to tier4/autoware.universe that referenced this pull request Oct 23, 2024
saka1-s pushed a commit to saka1-s/autoware.universe that referenced this pull request Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants