Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(obstacle_stop_planner): add test #599

Closed

Conversation

hrjp
Copy link

@hrjp hrjp commented Mar 29, 2022

Description

Added a part of the test code in obstacle_stop_planner package.
Only straight trajectory is used for the test since it will be hard to verify the function with the non-straight trajectory because of the distortion.

Related links

#597

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@takayuki5168 takayuki5168 self-requested a review March 29, 2022 02:21
@takayuki5168
Copy link
Contributor

Please make sure to pass the pre-commit

@codecov
Copy link

codecov bot commented Mar 29, 2022

Codecov Report

Merging #599 (237ba14) into main (ce8f2c3) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 237ba14 differs from pull request most recent head b06cc81. Consider uploading reports for the commit b06cc81 to get more accurate results

@@            Coverage Diff             @@
##             main     #599      +/-   ##
==========================================
- Coverage   10.75%   10.73%   -0.03%     
==========================================
  Files        1111     1111              
  Lines       78544    78726     +182     
  Branches    18555    18555              
==========================================
  Hits         8451     8451              
- Misses      61236    61418     +182     
  Partials     8857     8857              
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 10.74% <ø> (ø) Carriedforward from 9898734

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
planning/obstacle_stop_planner/src/node.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@takayuki5168 takayuki5168 requested a review from TakaHoribe March 29, 2022 06:31
@takayuki5168 takayuki5168 marked this pull request as draft April 23, 2022 12:01
@stale
Copy link

stale bot commented Jun 22, 2022

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Jun 22, 2022
@mitsudome-r
Copy link
Member

@hrjp This pr seems to be left as a draft for two months. Could you consider closing it until you are truly ready or could you finish the pr so the reviewers can review the PR?

@takayuki5168 takayuki5168 force-pushed the test/obstacle-stop-launch-testing branch from b45da4b to 9898734 Compare August 19, 2022 04:33
takayuki5168 and others added 2 commits August 19, 2022 13:48
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@yukkysaito
Copy link
Contributor

Since there is no reply, this PR is closed. Please reopen if necessary

@yukkysaito yukkysaito closed this Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:stale Inactive or outdated issues. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants