Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(motion_velocity_smoother): calc first point front_wheel_angle_rad #5989

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

VRichardJP
Copy link
Contributor

@VRichardJP VRichardJP commented Dec 28, 2023

Description

see #5964

Tests performed

After PR, the first point front_wheel_angle_rad is calculated:

header:
  stamp:
    sec: 1703741879
    nanosec: 946795572
  frame_id: map
points:
- time_from_start:
    sec: 0
    nanosec: 0
  pose:
    position:
      x: 3743.6276524283326
      y: 73751.62245752678
      z: 0.0
    orientation:
      x: 0.0
      y: 0.0
      z: 0.7743217436642739
      w: 0.6327920964177086
  longitudinal_velocity_mps: 0.25
  lateral_velocity_mps: 0.0
  acceleration_mps2: 0.10000000149011612
  heading_rate_rps: 0.0
  front_wheel_angle_rad: -0.17300020158290863
  rear_wheel_angle_rad: 0.0

Effects on system behavior

front_wheel_angle_rad is mostly unused, so little to no effect?

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 28, 2023
@satoshi-ota satoshi-ota added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 28, 2023
Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Attention: 549 lines in your changes are missing coverage. Please review.

Comparison is base (5218584) 14.57% compared to head (72cc84e) 14.52%.
Report is 4 commits behind head on main.

Files Patch % Lines
...ection_module/src/scene_intersection_collision.cpp 0.00% 246 Missing ⚠️
...elocity_intersection_module/src/object_manager.cpp 0.00% 126 Missing ⚠️
...ity_intersection_module/src/scene_intersection.cpp 0.00% 68 Missing ⚠️
...ehavior_velocity_intersection_module/src/debug.cpp 0.00% 23 Missing ⚠️
...locity_intersection_module/src/decision_result.cpp 0.00% 21 Missing ⚠️
...ion_module/src/scene_intersection_prepare_data.cpp 0.00% 21 Missing ⚠️
...elocity_intersection_module/src/object_manager.hpp 0.00% 20 Missing ⚠️
...tersection_module/src/scene_intersection_stuck.cpp 0.00% 8 Missing ⚠️
...ection_module/src/scene_intersection_occlusion.cpp 0.00% 7 Missing ⚠️
...havior_velocity_intersection_module/src/result.hpp 0.00% 4 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5989      +/-   ##
==========================================
- Coverage   14.57%   14.52%   -0.05%     
==========================================
  Files        1874     1877       +3     
  Lines      127709   127871     +162     
  Branches    37321    37412      +91     
==========================================
- Hits        18608    18569      -39     
- Misses      88182    88425     +243     
+ Partials    20919    20877      -42     
Flag Coverage Δ *Carryforward flag
differential 14.11% <0.18%> (?)
total 14.58% <ø> (+0.01%) ⬆️ Carriedforward from 1c4c3e3

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@satoshi-ota satoshi-ota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Vincent Richard <richard-v@macnica.co.jp>
@mehmetdogru mehmetdogru merged commit 0dc88f5 into autowarefoundation:main Feb 15, 2024
21 of 24 checks passed
@VRichardJP VRichardJP deleted the patch-6 branch February 20, 2024 03:10
StepTurtle pushed a commit to StepTurtle/autoware.universe that referenced this pull request Feb 28, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants