-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(motion_velocity_smoother): calc first point front_wheel_angle_rad #5989
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5989 +/- ##
==========================================
- Coverage 14.57% 14.52% -0.05%
==========================================
Files 1874 1877 +3
Lines 127709 127871 +162
Branches 37321 37412 +91
==========================================
- Hits 18608 18569 -39
- Misses 88182 88425 +243
+ Partials 20919 20877 -42
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Vincent Richard <richard-v@macnica.co.jp>
…autowarefoundation#5989) Signed-off-by: Vincent Richard <richard-v@macnica.co.jp>
…autowarefoundation#5989) Signed-off-by: Vincent Richard <richard-v@macnica.co.jp>
Description
see #5964
Tests performed
After PR, the first point
front_wheel_angle_rad
is calculated:Effects on system behavior
front_wheel_angle_rad
is mostly unused, so little to no effect?Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.