Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(perception-tensortt-yolo): rework parameters #5918

Merged
merged 3 commits into from
Dec 28, 2023

Conversation

karishma1911
Copy link
Contributor

@karishma1911 karishma1911 commented Dec 19, 2023

Description

Implement the ROS Node configuration layout described in https://github.com/orgs/autowarefoundation/discussions/3371 for the perception-tensortt-yolo

  1. Remove the default value from the source code in order to ensure all parameter values are passed from the parameter files.
  2. create schema

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@karishma1911 karishma1911 requested a review from wep21 as a code owner December 19, 2023 12:50
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Dec 19, 2023
Signed-off-by: karishma <karishma@interpl.ai>
@wep21 wep21 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 20, 2023
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (0dee512) 15.29% compared to head (d32a152) 15.20%.
Report is 10 commits behind head on main.

Files Patch % Lines
perception/tensorrt_yolo/src/nodelet.cpp 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5918      +/-   ##
==========================================
- Coverage   15.29%   15.20%   -0.09%     
==========================================
  Files        1748     1762      +14     
  Lines      120329   120988     +659     
  Branches    36693    36693              
==========================================
  Hits        18402    18402              
- Misses      81277    81936     +659     
  Partials    20650    20650              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 15.29% <ø> (ø) Carriedforward from 0dee512

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@wep21 wep21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshi-ota satoshi-ota merged commit 6efa91b into autowarefoundation:main Dec 28, 2023
31 of 35 checks passed
karishma1911 added a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
…tion#5918)

perception-tensortt-yolo

Signed-off-by: karishma <karishma@interpl.ai>
karishma1911 added a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…tion#5918)

perception-tensortt-yolo

Signed-off-by: karishma <karishma@interpl.ai>
karishma1911 added a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…tion#5918)

perception-tensortt-yolo

Signed-off-by: karishma <karishma@interpl.ai>
karishma1911 added a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…tion#5918)

perception-tensortt-yolo

Signed-off-by: karishma <karishma@interpl.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants