Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dummy_perception_publisher): modified objects also use baselink z-position #588

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Mar 28, 2022

Description

If objects do NOT use baselink z-position, the point cloud will be outside the boundary in the following section, and perception topic may not be output correctly.

if (min_z <= z && z <= max_z + epsilon) {
pcl::PointXYZ point;
point.x =
horizontal_candidate_pointcloud.at(pointcloud_index).x + x_random(random_generator_);
point.y =
horizontal_candidate_pointcloud.at(pointcloud_index).y + y_random(random_generator_);
point.z = z + z_random(random_generator_);
pointcloud_ptr->push_back(point);
}

So, this PR fix following point:

  • modified objects also use baselink z-position

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…-position

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #588 (0abf13a) into main (97786b9) will decrease coverage by 0.01%.
The diff coverage is 6.66%.

❗ Current head 0abf13a differs from pull request most recent head 7ae4569. Consider uploading reports for the commit 7ae4569 to get more accurate results

@@            Coverage Diff             @@
##             main     #588      +/-   ##
==========================================
- Coverage   10.89%   10.88%   -0.02%     
==========================================
  Files         706      706              
  Lines       49918    50006      +88     
  Branches     7117     6579     -538     
==========================================
+ Hits         5440     5443       +3     
- Misses      40096    40156      +60     
- Partials     4382     4407      +25     
Impacted Files Coverage Δ
...er/include/scene_module/occlusion_spot/manager.hpp 0.00% <ø> (ø)
...ene_module/occlusion_spot/occlusion_spot_utils.hpp 25.00% <ø> (-15.00%) ⬇️
...vior_velocity_planner/include/utilization/util.hpp 7.84% <ø> (+1.96%) ⬆️
..._planner/src/scene_module/occlusion_spot/debug.cpp 0.00% <0.00%> (ø)
...ner/src/scene_module/occlusion_spot/grid_utils.cpp 16.78% <0.00%> (-6.93%) ⬇️
...lanner/src/scene_module/occlusion_spot/manager.cpp 0.00% <0.00%> (ø)
...ene_module/occlusion_spot/occlusion_spot_utils.cpp 9.62% <0.00%> (-0.11%) ⬇️
..._module/occlusion_spot/risk_predictive_braking.cpp 49.05% <0.00%> (+0.66%) ⬆️
...ene_module/occlusion_spot/scene_occlusion_spot.cpp 0.00% <0.00%> (ø)
...behavior_velocity_planner/src/utilization/util.cpp 26.63% <0.00%> (-0.60%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97786b9...7ae4569. Read the comment docs.

Copy link
Contributor

@h-ohta h-ohta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshi-ota satoshi-ota merged commit 7168952 into autowarefoundation:main Mar 28, 2022
@satoshi-ota satoshi-ota deleted the fix/modified-objects-z-position branch March 28, 2022 05:58
satoshi-ota added a commit to satoshi-ota/autoware.universe that referenced this pull request Apr 25, 2022
…-position (autowarefoundation#588)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
…-position (tier4#588)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
…-position (tier4#588)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
…-position (tier4#588)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
…-position (tier4#588)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request Jul 3, 2023
…s-for-beta-v0.8.2

feat: cherry-picks for beta/v0.8.2
kyoichi-sugahara pushed a commit that referenced this pull request Sep 16, 2023
Signed-off-by: GitHub <noreply@github.com>
Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants