-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dummy_perception_publisher): modified objects also use baselink z-position #588
fix(dummy_perception_publisher): modified objects also use baselink z-position #588
Conversation
…-position Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #588 +/- ##
==========================================
- Coverage 10.89% 10.88% -0.02%
==========================================
Files 706 706
Lines 49918 50006 +88
Branches 7117 6579 -538
==========================================
+ Hits 5440 5443 +3
- Misses 40096 40156 +60
- Partials 4382 4407 +25
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…-position (autowarefoundation#588) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…-position (tier4#588) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…-position (tier4#588) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…-position (tier4#588) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…-position (tier4#588) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…s-for-beta-v0.8.2 feat: cherry-picks for beta/v0.8.2
Signed-off-by: GitHub <noreply@github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>
Description
If objects do NOT use baselink z-position, the point cloud will be outside the boundary in the following section, and perception topic may not be output correctly.
autoware.universe/simulator/dummy_perception_publisher/src/node.cpp
Lines 322 to 330 in 0abf13a
So, this PR fix following point:
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.