Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(traffic_light_visualization): move header directory to match package name #5864

Merged
merged 5 commits into from
Dec 14, 2023
Merged

fix(traffic_light_visualization): move header directory to match package name #5864

merged 5 commits into from
Dec 14, 2023

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Dec 13, 2023 •
edited
Loading

Description

This PR moves headers to a directory that matches the name of the package.

See autowarefoundation/autoware#4070

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@esteve
fix(traffic_light_visualization): move header directory to match pack…
7eff769 
…age name

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve esteve requested a review from yukkysaito as a code owner December 13, 2023 14:22
@esteve esteve added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 13, 2023
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Dec 13, 2023
yukkysaito
yukkysaito approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@esteve
fix: fix include
1c775b6 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve esteve enabled auto-merge (squash) December 14, 2023 13:07
@esteve
fix: fix include
71f8b15 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
fix: fix includes
a0d380c 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@codecov Codecov
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7477e9a) 15.33% compared to head (a0d380c) 15.33%.
Report is 7 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5864      +/-   ##
==========================================
- Coverage   15.33%   15.33%   -0.01%     
==========================================
  Files        1742     1744       +2     
  Lines      119971   119973       +2     
  Branches    36486    36486              
==========================================
  Hits        18403    18403              
- Misses      80978    80980       +2     
  Partials    20590    20590
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 15.33% <ø> (ø) Carriedforward from 7477e9a

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@esteve esteve merged commit 0ae2685 into autowarefoundation:main Dec 14, 2023
24 checks passed
@esteve esteve deleted the traffic-light-visualization-move-headers branch December 14, 2023 14:45
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Dec 15, 2023
@esteve @pre-commit-ci @danielsanchezaran
fix(traffic_light_visualization): move header directory to match pack…
0252a1f 
…age name (autowarefoundation#5864)

* fix(traffic_light_visualization): move header directory to match package name

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

* style(pre-commit): autofix

* fix: fix include

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

---------

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
@esteve @pre-commit-ci @karishma1911
fix(traffic_light_visualization): move header directory to match pack…
3e11f34 
…age name (autowarefoundation#5864)

* fix(traffic_light_visualization): move header directory to match package name

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

* style(pre-commit): autofix

* fix: fix include

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

---------

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: karishma <karishma@interpl.ai>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
@esteve @pre-commit-ci @karishma1911
fix(traffic_light_visualization): move header directory to match pack…
4a82d87 
…age name (autowarefoundation#5864)

* fix(traffic_light_visualization): move header directory to match package name

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

* style(pre-commit): autofix

* fix: fix include

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

---------

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: karishma <karishma@interpl.ai>
@esteve esteve mentioned this pull request Dec 19, 2023
Open
16 tasks
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Dec 20, 2023
Merged
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
@esteve @pre-commit-ci @karishma1911
fix(traffic_light_visualization): move header directory to match pack…
76f01e6 
…age name (autowarefoundation#5864)

* fix(traffic_light_visualization): move header directory to match package name

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

* style(pre-commit): autofix

* fix: fix include

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

---------

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
@esteve @pre-commit-ci @karishma1911
fix(traffic_light_visualization): move header directory to match pack…
7bdda89 
…age name (autowarefoundation#5864)

* fix(traffic_light_visualization): move header directory to match package name

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

* style(pre-commit): autofix

* fix: fix include

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

---------

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
@esteve @pre-commit-ci @karishma1911
fix(traffic_light_visualization): move header directory to match pack…
8d3bbaf 
…age name (autowarefoundation#5864)

* fix(traffic_light_visualization): move header directory to match package name

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

* style(pre-commit): autofix

* fix: fix include

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

---------

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yukkysaito yukkysaito yukkysaito approved these changes

Assignees
No one assigned
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@esteve @yukkysaito