refactor(run_out): boost::optional to std::optional #5760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
zulfaqar-azmi-t4
requested review from
mkuri,
shmpwk,
takayuki5168,
TomohitoAndo and
tkimura4
as code owners
github-actions
bot
added
the
component:planning
takayuki5168
approved these changes
Dec 4, 2023
zulfaqar-azmi-t4
added
the
run:build-and-test-differential
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5760 +/- ##
===========================================
+ Coverage 15.32% 18.98% +3.66%
===========================================
Files 1721 15 -1706
Lines 118559 1385 -117174
Branches 37995 684 -37311
===========================================
- Hits 18169 263 -17906
+ Misses 79657 823 -78834
+ Partials 20733 299 -20434
☔ View full report in Codecov by Sentry. |
kyoichi-sugahara
pushed a commit
to kyoichi-sugahara/autoware.universe
that referenced
this pull request
Dec 5, 2023
…on#5760) Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
danielsanchezaran
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Dec 15, 2023
…on#5760) Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…on#5760) Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: karishma <karishma@interpl.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🤖[deprecated] Generated by Copilot at 024a6b4
Refactored the code of the behavior velocity run out module to improve readability and reduce dependency on the boost library. Moved dynamic obstacle detection and handling functions to a separate file
dynamic_obstacle.cpp. Replacedboost::optionalwithstd::optionalin several files.Libraries and modules mixes between boost::optional and std::optional #5732
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.