-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(image_projection_based_fusion,lidar_centerpoint): add cuda preprocess #5681
Conversation
Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5681 +/- ##
==========================================
- Coverage 15.32% 0.00% -15.33%
==========================================
Files 1721 35 -1686
Lines 118559 1719 -116840
Branches 37995 0 -37995
==========================================
- Hits 18169 0 -18169
+ Misses 79657 1719 -77938
+ Partials 20733 0 -20733
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirmed that it works without any issue and execution time is reduced by this PR.
average delay of centerpoint: 0.232 → 0.217 |
Description
🤖[deprecated] Generated by Copilot at 6d9c35d
This pull request refactors and optimizes the code for the pointpainting fusion and centerpoint algorithms for 3D object detection. It introduces new CUDA functions and kernels for voxel generation and feature extraction, and improves the memory management and performance of the existing ones. It also renames and modifies some functions and classes to better reflect their functionality and simplify their interface. The main files affected are
pointpainting_trt.hpp
,preprocess_kernel.cu
,voxel_generator.cpp
, andcenterpoint_trt.cpp
.Related links
Tests performed
I've tested with rosbag and standalone launch file.
I've confirmed the pre-processing time decreases after implementing this PR.
Notes for reviewers
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.