fix(behavior_path_planner): fix turn signal endless loop

[kosuke55]

Description

fix turn signal endless loop
#5440

Tests performed

https://evaluation.tier4.jp/evaluation/reports/c40eba8d-7d8e-5aa6-9c33-071b5b7841ac?project_id=prd_jt
1665/1667

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

[codecov]

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (65f0a71) 14.76% compared to head (0ca67d3) 14.76%.
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5444      +/-   ##
==========================================
- Coverage   14.76%   14.76%   -0.01%     
==========================================
  Files        1663     1663              
  Lines      115772   115767       -5     
  Branches    35925    35923       -2     
==========================================
- Hits        17099    17096       -3     
  Misses      79310    79310              
+ Partials    19363    19361       -2     

Flag	Coverage Δ		*Carryforward flag
differential	12.17% <0.00%> (?)
total	14.76% <ø> (-0.01%)	⬇️	Carriedforward from 65f0a71

*This pull request uses carry forward flags. Click here to find out more.

Files	Coverage Δ
.../behavior_path_planner/src/turn_signal_decider.cpp	40.59% <0.00%> (-0.36%)	⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kosuke55]

@danielsanchezaran could you please review?

[kyoichi-sugahara]

@danielsanchezaran
First of all, thank you so much for the report!!!!! That's super helpful.
Could you review this PR and approve after your all comments are resolved?
And could you close the issue after merging this PR?
I will approve this PR because maintainer's approve is necessary and you are not the maintainer for now. But mergeing will be handled by @.kosuke55 san!

When close the issue, we really appreciate it if you upload the video that problem is solved.
(Just uploading the same video you shared internally

[kyoichi-sugahara]

LGTM!
(don't merge before @.danielsanchezaran san's approval 🙇

[danielsanchezaran]

@kosuke55 CC @kyoichi-sugahara
LGTM. Thanks for your quick response. With this fix the issue has been solved!

[danielsanchezaran]

LGTM!