Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ekf_localizer): remove unnecessary publishers #5423

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Oct 26, 2023

Description

Remove unnecessary debug publishers that makes the code difficult to read.

Tests performed

Build succeeds

Effects on system behavior

Two debug topics from EKF will no longer be published. Since these two topics are barely used, we see no negative impact on Autoware users.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kminoda <koji.minoda@tier4.jp>
@github-actions github-actions bot added the component:localization Vehicle's position determination in its environment. (auto-assigned) label Oct 26, 2023
@kminoda kminoda added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 26, 2023
@kminoda kminoda marked this pull request as ready for review October 26, 2023 14:20
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fdd671f) 14.73% compared to head (bf49aac) 14.84%.
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5423      +/-   ##
==========================================
+ Coverage   14.73%   14.84%   +0.11%     
==========================================
  Files        1661     1662       +1     
  Lines      115531   113836    -1695     
  Branches    35675    34879     -796     
==========================================
- Hits        17023    16903     -120     
+ Misses      79272    77900    -1372     
+ Partials    19236    19033     -203     
Flag Coverage Δ *Carryforward flag
differential 28.67% <ø> (?)
total 14.84% <ø> (+0.11%) ⬆️ Carriedforward from 910f30b

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...king/include/autonomous_emergency_braking/node.hpp 0.00% <ø> (ø)
control/autonomous_emergency_braking/src/node.cpp 0.00% <ø> (ø)
..._localizer/include/ekf_localizer/ekf_localizer.hpp 0.00% <ø> (ø)
localization/ekf_localizer/src/ekf_localizer.cpp 0.00% <ø> (ø)
...ased_localizer/src/ar_tag_based_localizer_core.cpp 0.00% <ø> (ø)
.../scene_module/goal_planner/goal_planner_module.hpp 0.00% <ø> (-28.31%) ⬇️
...r_path_planner/scene_module/lane_change/normal.hpp 0.00% <ø> (-50.00%) ⬇️
..._planner/utils/goal_planner/goal_searcher_base.hpp 20.00% <ø> (ø)
.../scene_module/goal_planner/goal_planner_module.cpp 5.98% <ø> (+0.71%) ⬆️
...th_planner/src/scene_module/lane_change/normal.cpp 4.45% <ø> (+0.59%) ⬆️
... and 2 more

... and 95 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Motsu-san Motsu-san left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow

@kminoda kminoda merged commit bfabbca into autowarefoundation:main Oct 27, 2023
22 of 23 checks passed
@kminoda kminoda deleted the fix/ekf_localizer/remove_unnecessary_debug_topic branch October 27, 2023 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants