Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(goal_planner): visualize stop wall #5408

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Oct 25, 2023

Description

stop_pose_ is removed in manager every loop, so need to set every loop.

after

image

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Oct 25, 2023
@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 25, 2023
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (6e60536) 14.75% compared to head (ce98da4) 14.75%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5408      +/-   ##
==========================================
- Coverage   14.75%   14.75%   -0.01%     
==========================================
  Files        1661     1661              
  Lines      115514   115533      +19     
  Branches    35666    35679      +13     
==========================================
  Hits        17049    17049              
- Misses      79223    79239      +16     
- Partials    19242    19245       +3     
Flag Coverage Δ *Carryforward flag
differential 12.33% <4.16%> (?)
total 14.75% <ø> (-0.01%) ⬇️ Carriedforward from 6e60536

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
..._planner/utils/avoidance/avoidance_module_data.hpp 0.00% <ø> (ø)
.../scene_module/goal_planner/goal_planner_module.cpp 5.25% <0.00%> (-0.02%) ⬇️
planning/behavior_path_planner/src/utils/utils.cpp 13.72% <0.00%> (-0.02%) ⬇️
...ath_planner/src/scene_module/avoidance/manager.cpp 6.13% <25.00%> (+0.27%) ⬆️
...ing/behavior_path_planner/src/utils/path_utils.cpp 13.76% <0.00%> (-0.23%) ⬇️
...er/src/scene_module/avoidance/avoidance_module.cpp 12.09% <0.00%> (-0.14%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kosuke55 kosuke55 merged commit 0af019e into main Oct 27, 2023
35 of 39 checks passed
@kosuke55 kosuke55 deleted the fix/goal_planner_stop_pose branch October 27, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants