refactor(emergency_handler): rework parameters #5242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type:documentation
satoshi-ota
added
the
run:build-and-test-differential
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5242 +/- ##
==========================================
- Coverage 15.32% 0.00% -15.33%
==========================================
Files 1721 3 -1718
Lines 118559 210 -118349
Branches 37995 0 -37995
==========================================
- Hits 18169 0 -18169
+ Misses 79657 210 -79447
+ Partials 20733 0 -20733
☔ View full report in Codecov by Sentry. |
Signed-off-by: Yuqi Huai <yhuai@uci.edu>
satoshi-ota
force-pushed
the
refactor/emergency_handler
branch
from
6ae6462 to
da616c7
Compare
danielsanchezaran
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Dec 15, 2023
* refactor(emergency_handler): rework parameters Signed-off-by: Yuqi Huai <yhuai@uci.edu> * style(pre-commit): autofix --------- Signed-off-by: Yuqi Huai <yhuai@uci.edu> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor the ROS Node configuration layout for the detection_by_tracker package according to the guideline.
Related links
None.
Tests performed
colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release --packages-up-to emergency_handlerros2 launch emergency_handler emergency_handler.launch.xmlNotes for reviewers
None.
Interface changes
declare_parameterEffects on system behavior
None.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.