-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(raw_vehicle_cmd_converter): rework parameters #5134
refactor(raw_vehicle_cmd_converter): rework parameters #5134
Conversation
Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com>
Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com>
Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com>
Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com>
vehicle/raw_vehicle_cmd_converter/launch/raw_vehicle_converter.launch.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com>
Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com>
@ambroise-arm @satoshi-ota Hi, the failure of json schema check seems because of the error schema setting in behavior_velocity_planner node |
@PhoebeWu21 Thanks 👍 |
@PhoebeWu21 #5676 was merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for your PR.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5134 +/- ##
===========================================
- Coverage 15.32% 10.52% -4.81%
===========================================
Files 1721 14 -1707
Lines 118559 1416 -117143
Branches 37995 166 -37829
===========================================
- Hits 18169 149 -18020
+ Misses 79657 1126 -78531
+ Partials 20733 141 -20592
☔ View full report in Codecov by Sentry. |
…ation#5134) * refactor(raw_vehicle_cmd_converter): rework parameters Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com> * refactor(raw_vehicle_cmd_converter): rework parameters Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com> * style(pre-commit): autofix * refactor(raw_vehicle_cmd_converter): rework parameters Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com> * refactor(raw_vehicle_cmd_converter): rework parameters Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com> * refactor(raw_vehicle_cmd_converter): rework parameters Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com> * refactor(raw_vehicle_cmd_converter): rework parameters Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com> --------- Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Description
Implement the ROS Node configuration layout described in https://github.com/orgs/autowarefoundation/discussions/3371 for the
raw_vehicle_cmd_converter
package.Tests performed
Package build and launch locally.
colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release --packages-up-to raw_vehicle_cmd_converter
Effects on system behavior
More reliable and faster parameter configuration file creation.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.