Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(raw_vehicle_cmd_converter): rework parameters #5134

Conversation

PhoebeWu21
Copy link
Member

@PhoebeWu21 PhoebeWu21 commented Sep 26, 2023

Description

Implement the ROS Node configuration layout described in https://github.com/orgs/autowarefoundation/discussions/3371 for the raw_vehicle_cmd_converter package.

  • Remove the default value from the source code in order to ensure all parameter values are passed from the parameter files.
  • Create the schema

Tests performed

Package build and launch locally.
colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release --packages-up-to raw_vehicle_cmd_converter

Effects on system behavior

More reliable and faster parameter configuration file creation.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com>
Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com>
@github-actions github-actions bot added the component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) label Sep 26, 2023
Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com>
@github-actions github-actions bot added the type:documentation Creating or refining documentation. (auto-assigned) label Nov 10, 2023
Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com>
Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com>
Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com>
@PhoebeWu21
Copy link
Member Author

PhoebeWu21 commented Nov 24, 2023

@ambroise-arm @satoshi-ota Hi, the failure of json schema check seems because of the error schema setting in behavior_velocity_planner node
image

@satoshi-ota
Copy link
Contributor

@PhoebeWu21 Thanks 👍
I created fix PR. Could you review it?
#5676

@satoshi-ota
Copy link
Contributor

satoshi-ota commented Nov 26, 2023

@PhoebeWu21 #5676 was merged.

@satoshi-ota satoshi-ota added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 28, 2023
Copy link
Contributor

@taikitanaka3 taikitanaka3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Copy link
Contributor

@TakaHoribe TakaHoribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your PR.

@satoshi-ota satoshi-ota enabled auto-merge (squash) November 28, 2023 13:27
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (765a596) 15.32% compared to head (7123df8) 10.52%.
Report is 88 commits behind head on main.

Files Patch % Lines
vehicle/raw_vehicle_cmd_converter/src/node.cpp 0.00% 25 Missing ⚠️
vehicle/external_cmd_converter/src/node.cpp 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5134       +/-   ##
===========================================
- Coverage   15.32%   10.52%    -4.81%     
===========================================
  Files        1721       14     -1707     
  Lines      118559     1416   -117143     
  Branches    37995      166    -37829     
===========================================
- Hits        18169      149    -18020     
+ Misses      79657     1126    -78531     
+ Partials    20733      141    -20592     
Flag Coverage Δ
differential 10.52% <0.00%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@satoshi-ota satoshi-ota merged commit 9f2f036 into autowarefoundation:main Nov 29, 2023
30 of 34 checks passed
@PhoebeWu21 PhoebeWu21 deleted the refactor-node-config-raw_vehicle_cmd_converter branch November 29, 2023 00:50
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Dec 15, 2023
…ation#5134)

* refactor(raw_vehicle_cmd_converter): rework parameters

Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com>

* refactor(raw_vehicle_cmd_converter): rework parameters

Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com>

* style(pre-commit): autofix

* refactor(raw_vehicle_cmd_converter): rework parameters

Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com>

* refactor(raw_vehicle_cmd_converter): rework parameters

Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com>

* refactor(raw_vehicle_cmd_converter): rework parameters

Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com>

* refactor(raw_vehicle_cmd_converter): rework parameters

Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com>

---------

Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants