Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ar_tag_based_localizer): add diagnostic #5132

Merged

Conversation

SakodaShintaro
Copy link
Contributor

@SakodaShintaro SakodaShintaro commented Sep 26, 2023

Description

Outputs the number of AR tags detected to /diagnostics.
When the number of detections is 1 or more, it is output as OK, and when it is 0, it is output as warn.

The main purpose of this /diagnostics is to confirm that the node is alive with DrivingLogReplayer, rather than properly monitoring its actual health.

diag_warn

diag_ok

Tests performed

The sample data for the ar_tag_based_localizer (AWSIM version) was run in logging_simulator to confirm the same performance as before.

Effects on system behavior

For ar_tag_based_localizer, diagnostic publish was added.

The default autoware is not affected.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp>
Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp>
Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp>
@SakodaShintaro SakodaShintaro self-assigned this Sep 26, 2023
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) labels Sep 26, 2023
@SakodaShintaro SakodaShintaro added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 26, 2023
@SakodaShintaro SakodaShintaro enabled auto-merge (squash) September 26, 2023 06:47
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (443386d) 14.91% compared to head (d14b6ee) 14.91%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5132      +/-   ##
==========================================
- Coverage   14.91%   14.91%   -0.01%     
==========================================
  Files        1625     1625              
  Lines      112412   112427      +15     
  Branches    34699    34699              
==========================================
  Hits        16764    16764              
- Misses      76910    76925      +15     
  Partials    18738    18738              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 14.91% <ø> (ø) Carriedforward from 443386d

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...ased_localizer/src/ar_tag_based_localizer_core.cpp 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SakodaShintaro SakodaShintaro merged commit 72e7855 into autowarefoundation:main Sep 26, 2023
@SakodaShintaro SakodaShintaro deleted the feat/add_diagnostic branch September 26, 2023 10:03
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Sep 26, 2023
* Added diagnostic

Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp>

* Fixed key name

Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp>

* Updated README.md

Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants