-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ar_tag_based_localizer): add diagnostic #5132
Merged
SakodaShintaro
merged 5 commits into
autowarefoundation:main
from
SakodaShintaro:feat/add_diagnostic
Sep 26, 2023
Merged
feat(ar_tag_based_localizer): add diagnostic #5132
SakodaShintaro
merged 5 commits into
autowarefoundation:main
from
SakodaShintaro:feat/add_diagnostic
Sep 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp>
Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp>
Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp>
github-actions
bot
added
type:documentation
Creating or refining documentation. (auto-assigned)
component:localization
Vehicle's position determination in its environment. (auto-assigned)
labels
Sep 26, 2023
SakodaShintaro
added
the
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Sep 26, 2023
YamatoAndo
approved these changes
Sep 26, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5132 +/- ##
==========================================
- Coverage 14.91% 14.91% -0.01%
==========================================
Files 1625 1625
Lines 112412 112427 +15
Branches 34699 34699
==========================================
Hits 16764 16764
- Misses 76910 76925 +15
Partials 18738 18738
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
kyoichi-sugahara
pushed a commit
to kyoichi-sugahara/autoware.universe
that referenced
this pull request
Sep 26, 2023
* Added diagnostic Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp> * Fixed key name Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp> * Updated README.md Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp> * style(pre-commit): autofix --------- Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:localization
Vehicle's position determination in its environment. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
type:documentation
Creating or refining documentation. (auto-assigned)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Outputs the number of AR tags detected to
/diagnostics
.When the number of detections is 1 or more, it is output as OK, and when it is 0, it is output as warn.
The main purpose of this
/diagnostics
is to confirm that the node is alive with DrivingLogReplayer, rather than properly monitoring its actual health.Tests performed
The sample data for the
ar_tag_based_localizer
(AWSIM version) was run inlogging_simulator
to confirm the same performance as before.Effects on system behavior
For
ar_tag_based_localizer
, diagnostic publish was added.The default autoware is not affected.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.