Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): remove tier4_autoware_utils.hpp/motion_utils.hpp from behavior_path_planner #4936

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Sep 9, 2023

Description

depends #4934

#4821

Tests performed

none

Effects on system behavior

none

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Sep 9, 2023
@soblin soblin force-pushed the build-fast2/component/planning/behavior_path/remove-motion_utils_motion_utils_hpp branch from 814a14a to 6426a14 Compare September 9, 2023 15:25
…lanner

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@soblin soblin force-pushed the build-fast2/component/planning/behavior_path/remove-motion_utils_motion_utils_hpp branch from 6426a14 to 3ff3195 Compare September 9, 2023 16:36
@soblin soblin marked this pull request as ready for review September 9, 2023 16:39
@soblin soblin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 9, 2023
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@@ -17,6 +17,7 @@
#include "behavior_path_planner/utils/goal_planner/util.hpp"
#include "behavior_path_planner/utils/path_utils.hpp"
#include "behavior_path_planner/utils/start_goal_planner_common/utils.hpp"
#include "motion_utils/trajectory/path_with_lane_id.hpp"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace with #include <tier4_autoware_utils/geometry/path_with_lane_id_geometry.hpp>

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@codecov
Copy link

codecov bot commented Sep 10, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.11% 🎉

Comparison is base (94838a9) 15.92% compared to head (b715633) 16.03%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4936      +/-   ##
==========================================
+ Coverage   15.92%   16.03%   +0.11%     
==========================================
  Files        1580     1580              
  Lines      109004   109287     +283     
  Branches    33611    33811     +200     
==========================================
+ Hits        17355    17523     +168     
- Misses      73034    73103      +69     
- Partials    18615    18661      +46     
Flag Coverage Δ *Carryforward flag
differential 18.49% <ø> (?)
total 15.92% <ø> (ø) Carriedforward from 94838a9

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...ner/include/behavior_path_planner/data_manager.hpp 50.00% <ø> (ø)
...clude/behavior_path_planner/marker_utils/utils.hpp 0.00% <ø> (ø)
.../include/behavior_path_planner/planner_manager.hpp 50.00% <ø> (ø)
...th_planner/scene_module/scene_module_interface.hpp 36.36% <ø> (ø)
..._planner/utils/avoidance/avoidance_module_data.hpp 0.00% <ø> (ø)
...nner/include/behavior_path_planner/utils/utils.hpp 45.45% <ø> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 30.85% <ø> (+0.55%) ⬆️
..._path_planner/src/marker_utils/avoidance/debug.cpp 5.16% <ø> (ø)
...g/behavior_path_planner/src/marker_utils/utils.cpp 18.15% <ø> (ø)
...ning/behavior_path_planner/src/planner_manager.cpp 37.00% <ø> (ø)
... and 33 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soblin soblin merged commit a25cbe0 into autowarefoundation:main Sep 10, 2023
@soblin soblin deleted the build-fast2/component/planning/behavior_path/remove-motion_utils_motion_utils_hpp branch September 10, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants