Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(start_planner): prevent approval when stop path #4932

Merged
merged 1 commit into from
Sep 10, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Sep 8, 2023

Description

prevent approval when stop path

image

Related links

tier internal ticket
https://tier4.atlassian.net/browse/RT1-3776?focusedCommentId=137031&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-137031

Tests performed

psim

https://evaluation.tier4.jp/evaluation/reports/3a94abc1-0c67-5352-b5f0-f39814ba4b79?project_id=prd_jt
1650/1650

Notes for reviewers

none

Interface changes

none

Effects on system behavior

can not approve when stop path is used

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 8, 2023
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Sep 8, 2023
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank youuuuu!

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch coverage: 20.00% and no project coverage change.

Comparison is base (49f3bd6) 15.93% compared to head (6997c55) 15.94%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4932   +/-   ##
=======================================
  Coverage   15.93%   15.94%           
=======================================
  Files        1580     1580           
  Lines      108931   108904   -27     
  Branches    33612    33617    +5     
=======================================
+ Hits        17356    17361    +5     
+ Misses      72958    72927   -31     
+ Partials    18617    18616    -1     
Flag Coverage Δ *Carryforward flag
differential 18.49% <20.00%> (?)
total 15.93% <ø> (+<0.01%) ⬆️ Carriedforward from 49f3bd6

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...planning_rviz_plugin/include/path/display_base.hpp 0.00% <ø> (ø)
...ing/surround_obstacle_checker/src/debug_marker.cpp 0.00% <ø> (ø)
planning/surround_obstacle_checker/src/node.cpp 0.00% <ø> (ø)
...cene_module/start_planner/start_planner_module.cpp 36.30% <20.00%> (+0.03%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 force-pushed the fix/stop_path_approval branch from 1a7bf7d to 6997c55 Compare September 9, 2023 06:18
@kosuke55 kosuke55 merged commit 477ce95 into main Sep 10, 2023
@kosuke55 kosuke55 deleted the fix/stop_path_approval branch September 10, 2023 06:37
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Sep 12, 2023
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Sep 12, 2023
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants