-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(start_planner): prevent approval when stop path #4932
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank youuuuu!
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4932 +/- ##
=======================================
Coverage 15.93% 15.94%
=======================================
Files 1580 1580
Lines 108931 108904 -27
Branches 33612 33617 +5
=======================================
+ Hits 17356 17361 +5
+ Misses 72958 72927 -31
+ Partials 18617 18616 -1
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
1a7bf7d
to
6997c55
Compare
…on#4932) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…on#4932) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…on#4932) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Description
prevent approval when stop path
Related links
tier internal ticket
https://tier4.atlassian.net/browse/RT1-3776?focusedCommentId=137031&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-137031
Tests performed
psim
https://evaluation.tier4.jp/evaluation/reports/3a94abc1-0c67-5352-b5f0-f39814ba4b79?project_id=prd_jt
1650/1650
Notes for reviewers
none
Interface changes
none
Effects on system behavior
can not approve when stop path is used
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.