-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(planning_debug_tools): support old auto TrafficSignalArray #4910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
label
Sep 7, 2023
7 tasks
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55
force-pushed
the
feat/auto_traffic_signals_planning_debug_tools
branch
from
September 7, 2023 03:56
c18449b
to
16beb73
Compare
kosuke55
added
the
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Sep 7, 2023
takayuki5168
approved these changes
Sep 7, 2023
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #4910 +/- ##
=======================================
Coverage 15.86% 15.86%
=======================================
Files 1578 1578
Lines 108839 108839
Branches 33566 33566
=======================================
Hits 17272 17272
Misses 72999 72999
Partials 18568 18568
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here. |
TomohitoAndo
approved these changes
Sep 7, 2023
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@TakaHoribe Could you approve as a code owner? |
TakaHoribe
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
support old auto TrafficSignalArray temporary
#4133 (comment)
fix the issue with old rosbag
Related links
Tests performed
run with only old bag
Notes for reviewers
noen
Interface changes
none
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.