Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(planning_debug_tools): support old auto TrafficSignalArray #4910

Merged
merged 2 commits into from
Sep 8, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Sep 7, 2023

Description

support old auto TrafficSignalArray temporary

#4133 (comment)

fix the issue with old rosbag

$ ros2 run planning_debug_tools perception_replayer.py -b /media/kosuke55/sandisk/rosbag/start_planner_stop_publishing_path/d4d1adc7-4fdf-4613-86b3-0daa2d945b9e_2023-08-25-13-41-44_p0900_5.db3
Stared loading rosbag
[INFO 1694057248.905715364] [rosbag2_storage]: Opened database '/media/kosuke55/sandisk/rosbag/start_planner_stop_publishing_path/d4d1adc7-4fdf-4613-86b3-0daa2d945b9e_2023-08-25-13-41-44_p0900_5.db3' for READ_ONLY. (open() at ./src/rosbag2_storage_default_plugins/sqlite/sqlite_storage.cpp:227)
Ended loading rosbag
Start timer callback
autoware_auto_perception_msgs.msg._traffic_signal_array
Traceback (most recent call last):
  File "/home/kosuke55/pilot-auto/install/planning_debug_tools/lib/planning_debug_tools/perception_replayer.py", line 189, in <module>
    rclpy.spin_once(node, timeout_sec=0.01)
  File "/opt/ros/humble/local/lib/python3.10/dist-packages/rclpy/__init__.py", line 202, in spin_once
    executor.spin_once(timeout_sec=timeout_sec)
  File "/opt/ros/humble/local/lib/python3.10/dist-packages/rclpy/executors.py", line 713, in spin_once
    raise handler.exception()
  File "/opt/ros/humble/local/lib/python3.10/dist-packages/rclpy/task.py", line 239, in __call__
    self._handler.send(None)
  File "/opt/ros/humble/local/lib/python3.10/dist-packages/rclpy/executors.py", line 418, in handler
    await call_coroutine(entity, arg)
  File "/opt/ros/humble/local/lib/python3.10/dist-packages/rclpy/executors.py", line 332, in _execute_timer
    await await_or_execute(tmr.callback)
  File "/opt/ros/humble/local/lib/python3.10/dist-packages/rclpy/executors.py", line 107, in await_or_execute
    return callback(*args)
  File "/home/kosuke55/pilot-auto/install/planning_debug_tools/lib/planning_debug_tools/perception_replayer.py", line 102, in on_timer
    traffic_signals_msg.stamp = timestamp
AttributeError: 'TrafficSignalArray' object has no attribute 'stamp'
[ros2run]: Process exited with failure 1

Related links

Tests performed

run with only old bag

Notes for reviewers

noen

Interface changes

none

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Sep 7, 2023
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 force-pushed the feat/auto_traffic_signals_planning_debug_tools branch from c18449b to 16beb73 Compare September 7, 2023 03:56
@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 7, 2023
@kosuke55
Copy link
Contributor Author

kosuke55 commented Sep 7, 2023

cc @maxime-clem @kyoichi-sugahara

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0ab6a3b) 15.86% compared to head (ad45cff) 15.86%.
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4910   +/-   ##
=======================================
  Coverage   15.86%   15.86%           
=======================================
  Files        1578     1578           
  Lines      108839   108839           
  Branches    33566    33566           
=======================================
  Hits        17272    17272           
  Misses      72999    72999           
  Partials    18568    18568           
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 15.86% <ø> (ø) Carriedforward from 16beb73

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55
Copy link
Contributor Author

kosuke55 commented Sep 8, 2023

@TakaHoribe Could you approve as a code owner?

@kosuke55 kosuke55 merged commit 61fef17 into main Sep 8, 2023
@kosuke55 kosuke55 deleted the feat/auto_traffic_signals_planning_debug_tools branch September 8, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants