Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tier4_planning_rviz_plugin): update vehicle info parameters in panel received from global parameter #4907

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Sep 6, 2023

Description

The vehicle size parameters of the path rviz plugin are received from the global parameter.
These parameters are applied to the plugin's footprint size but not to the parameters shown in the panel.

Tests performed

rviz

Effects on system behavior

Nothing

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…nel received from global parameter

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 marked this pull request as ready for review September 6, 2023 13:40
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Sep 6, 2023
@takayuki5168 takayuki5168 added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed component:common Common packages from the autoware-common repository. (auto-assigned) labels Sep 6, 2023
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c8f826d) 15.89% compared to head (632d4dc) 15.89%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4907   +/-   ##
=======================================
  Coverage   15.89%   15.89%           
=======================================
  Files        1578     1578           
  Lines      108871   108846   -25     
  Branches    33591    33573   -18     
=======================================
  Hits        17303    17303           
+ Misses      72989    72964   -25     
  Partials    18579    18579           
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 15.89% <ø> (+<0.01%) ⬆️ Carriedforward from c8f826d

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...planning_rviz_plugin/include/path/display_base.hpp 0.00% <0.00%> (ø)
...er/src/scene_module/avoidance/avoidance_module.cpp 11.54% <ø> (+0.03%) ⬆️
.../scene_module/goal_planner/goal_planner_module.cpp 8.02% <ø> (+0.05%) ⬆️
...ner/src/utils/goal_planner/freespace_pull_over.cpp 13.55% <ø> (+0.22%) ⬆️
...ner/src/utils/goal_planner/geometric_pull_over.cpp 21.73% <ø> (+0.90%) ⬆️
...h_planner/src/utils/goal_planner/goal_searcher.cpp 2.02% <ø> (+0.02%) ⬆️
...planner/src/utils/goal_planner/shift_pull_over.cpp 3.66% <ø> (+0.09%) ⬆️
...avior_path_planner/src/utils/goal_planner/util.cpp 7.35% <ø> (+0.77%) ⬆️
planning/route_handler/src/route_handler.cpp 27.55% <ø> (+0.11%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@takayuki5168 takayuki5168 merged commit 85f8db3 into autowarefoundation:main Sep 9, 2023
@takayuki5168 takayuki5168 deleted the fix/path-rviz-plugin-update-vehicle-info-main branch September 9, 2023 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants