feat(operation_transition_mannager): add param enable_engage_on_driving #4891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
github-actions
bot
added
type:documentation
4 tasks
takayuki5168
approved these changes
Sep 6, 2023
tkimura4
added
the
run:build-and-test-differential
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Because it is danger to engage the autonomous driving mode when the vehicle is moving without any consideration (it causes e.g. a danger deceleration), I added a parameter to prohibit the engage on driving.
When this parameter is false, the engage is prohibited anytime the vehicle is moving.
Related links
Need to be merged with autowarefoundation/autoware_launch#553
Tests performed
Run psim
Notes for reviewers
None
Interface changes
None
Effects on system behavior
Vehicle engage is not permitted depending on the parameter.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.