Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(operation_transition_manager): update readme #4888

Merged
merged 2 commits into from
Sep 8, 2023

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Sep 5, 2023

Description

Add images for the operation_transition_manager

Tests performed

None

Effects on system behavior

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@TakaHoribe TakaHoribe requested a review from tkimura4 as a code owner September 5, 2023 07:59
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) labels Sep 5, 2023
@TakaHoribe TakaHoribe added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 7, 2023
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Patch coverage: 20.71% and project coverage change: +0.06% 🎉

Comparison is base (3a370d4) 15.10% compared to head (c81753c) 15.16%.
Report is 47 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4888      +/-   ##
==========================================
+ Coverage   15.10%   15.16%   +0.06%     
==========================================
  Files        1577     1578       +1     
  Lines      108587   108606      +19     
  Branches    33339    33368      +29     
==========================================
+ Hits        16398    16470      +72     
+ Misses      74312    74222      -90     
- Partials    17877    17914      +37     
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 15.17% <20.71%> (+0.07%) ⬆️ Carriedforward from 26086bf

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
control/autonomous_emergency_braking/src/node.cpp 0.00% <ø> (ø)
.../lane_departure_checker/lane_departure_checker.hpp 0.00% <ø> (ø)
.../mpc_lateral_controller/mpc_lateral_controller.hpp 33.33% <0.00%> (-33.34%) ⬇️
control/mpc_lateral_controller/src/mpc.cpp 46.73% <ø> (ø)
control/mpc_lateral_controller/src/mpc_utils.cpp 50.44% <ø> (ø)
...ol/operation_mode_transition_manager/src/state.cpp 0.00% <ø> (ø)
...tudinal_controller/pid_longitudinal_controller.hpp 28.57% <ø> (ø)
...c/pure_pursuit/pure_pursuit_lateral_controller.cpp 0.00% <0.00%> (ø)
...y_follower_node/src/simple_trajectory_follower.cpp 0.00% <ø> (ø)
control/vehicle_cmd_gate/src/vehicle_cmd_gate.hpp 0.00% <ø> (ø)
... and 33 more

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkimura4 tkimura4 merged commit cd3956e into autowarefoundation:main Sep 8, 2023
@tkimura4 tkimura4 deleted the omtm-readme branch September 8, 2023 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants