Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): remove tier4_autoware_utils.hpp perception/ #4843

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Sep 1, 2023

Description

#4821

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Sep 1, 2023
@soblin soblin changed the title chore(build): remove tier4 autoware utils hpp perception/ chore(build): remove tier4_autoware_utils.hpp perception/ Sep 1, 2023
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@soblin soblin force-pushed the build-fast2/component/perception/remove-tier4_autoware_utils_hpp branch from d945592 to ed8fe35 Compare September 1, 2023 04:33
@github-actions github-actions bot removed component:planning Route planning, decision-making, and navigation. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Sep 1, 2023
@soblin soblin marked this pull request as ready for review September 1, 2023 06:20
@soblin soblin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 1, 2023
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.15% ⚠️

Comparison is base (26086bf) 15.17% compared to head (7fe665a) 15.03%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4843      +/-   ##
==========================================
- Coverage   15.17%   15.03%   -0.15%     
==========================================
  Files        1578     1600      +22     
  Lines      108562   108915     +353     
  Branches    33370    32998     -372     
==========================================
- Hits        16470    16371      -99     
- Misses      74176    74805     +629     
+ Partials    17916    17739     -177     
Flag Coverage Δ *Carryforward flag
differential 2.81% <ø> (?)
total 15.16% <ø> (-0.02%) ⬇️ Carriedforward from ed8fe35

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...e/obstacle_pointcloud_based_validator/debugger.hpp 0.00% <ø> (ø)
...ed_object_validation/src/object_lanelet_filter.cpp 0.00% <ø> (ø)
...d_object_validation/src/object_position_filter.cpp 0.00% <ø> (ø)
...dation/src/obstacle_pointcloud_based_validator.cpp 0.00% <ø> (ø)
..._validation/src/occupancy_grid_based_validator.cpp 0.00% <ø> (ø)
..._tracker/include/detection_by_tracker/debugger.hpp 0.00% <ø> (ø)
...detection_by_tracker/detection_by_tracker_core.hpp 0.00% <ø> (ø)
...ction_by_tracker/src/detection_by_tracker_core.cpp 0.00% <ø> (ø)
...ity_estimator/front_vehicle_velocity_estimator.hpp 0.00% <ø> (ø)
...stimator_node/front_vehicle_velocity_estimator.cpp 0.00% <ø> (ø)
... and 34 more

... and 90 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

Copy link
Contributor

@yukke42 yukke42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miursh miursh merged commit ed511b1 into autowarefoundation:main Sep 5, 2023
@soblin soblin deleted the build-fast2/component/perception/remove-tier4_autoware_utils_hpp branch September 5, 2023 02:19
miursh added a commit to miursh/autoware.universe that referenced this pull request Sep 12, 2023
miursh added a commit to miursh/autoware.universe that referenced this pull request Sep 12, 2023
TomohitoAndo pushed a commit to tier4/autoware.universe that referenced this pull request Mar 11, 2024
…undation#4843)

removed tier4_autoware_utils.hpp in perception/

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Co-authored-by: Shunsuke Miura <37187849+miursh@users.noreply.github.com>
TomohitoAndo added a commit to tier4/autoware.universe that referenced this pull request Mar 11, 2024
* chore(build): remove tier4_autoware_utils.hpp perception/ (autowarefoundation#4843)

removed tier4_autoware_utils.hpp in perception/

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Co-authored-by: Shunsuke Miura <37187849+miursh@users.noreply.github.com>

* feat(multi_object_tracker): mot bicycle model revision (autowarefoundation#6082)

* fix: bicycle model length on big vehicle

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* fix: rear axis position fix in all modalities

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* fix: repeat predict to limit dt

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* fix: implement repeating prediction to all modalities

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* fix: bicycle model revision

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* fix: fix centripetal acceleration,  jacobian

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* style(pre-commit): autofix

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* chore: equation on description, velocity index fix

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* fix: markdown math

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* chore: refactor params

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* feat: model slip process rate

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* feat: yaw rate limits

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* chore: refactor vx to vel, follow actual definition

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* fix: acceleration uncertainty equation fix

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* fix: twist covariance matrix

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* chore: explanations of Kalman filter matrices

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* feat: slip angle process noise model revised

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* feat: parameter tuning

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* fix: use mahalanobis distance gate with larger threshold

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* chore: align tracker format

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Yoshi Ri <yoshiyoshidetteiu@gmail.com>
Co-authored-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>

* fix(multi_object_tracker): bicycle motion model - set minimum wheel-to-center length (autowarefoundation#6337)

* fix: bicycle motion model - set minimum wheel-to-center length for stability

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* chore: align comments

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

---------

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

---------

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Co-authored-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Co-authored-by: Shunsuke Miura <37187849+miursh@users.noreply.github.com>
Co-authored-by: Taekjin LEE <technolojin@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Yoshi Ri <yoshiyoshidetteiu@gmail.com>
Co-authored-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants