-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(behavior_path_planner): fix reservation of predicted path #474
Merged
tkimura4
merged 1 commit into
autowarefoundation:main
from
rej55:fix/predicted_path_reservation
Mar 3, 2022
Merged
fix(behavior_path_planner): fix reservation of predicted path #474
tkimura4
merged 1 commit into
autowarefoundation:main
from
rej55:fix/predicted_path_reservation
Mar 3, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Before merging PR: behavior_path_planner died with the following error message with lane change situation.
|
tkimura4
approved these changes
Mar 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tkimura4
referenced
this pull request
in tier4/autoware.universe
Mar 3, 2022
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
satoshi-ota
pushed a commit
to satoshi-ota/autoware.universe
that referenced
this pull request
May 20, 2022
…refoundation#474) Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
satoshi-ota
pushed a commit
to satoshi-ota/autoware.universe
that referenced
this pull request
May 31, 2022
…refoundation#474) Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
TomohitoAndo
pushed a commit
to TomohitoAndo/autoware.universe
that referenced
this pull request
Oct 5, 2022
…velop sync main for develop
tkimura4
referenced
this pull request
in tier4/autoware.universe
Oct 24, 2022
Signed-off-by: GitHub <noreply@github.com> Signed-off-by: GitHub <noreply@github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>
keiota
pushed a commit
to keiota/autoware.universe
that referenced
this pull request
Aug 17, 2023
…dation#474) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
HansOersted
pushed a commit
to HansOersted/autoware.universe
that referenced
this pull request
Mar 8, 2024
YamatoAndo
pushed a commit
to YamatoAndo/autoware.universe
that referenced
this pull request
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Fumiya Watanabe rej55.g@gmail.com
Related Issue(required)
Description(required)
The size of path in
autoware_auto_perception_msgs::msg::PredictedPath
is limited to 100.However, in
behavior_path_planner
package, it may reserve the path points over 100.In this PR, I fixed it.
Review Procedure(required)
Please run the car on the long path with lane change without auto approval.
To turn-off the auto approval, please comment out here.
https://github.com/tier4/autoware_launch/blob/31fe5912a2d4eb5caadc6803df85ff14f78318ff/planning_launch/launch/scenario_planning/lane_driving/behavior_planning/behavior_planning.launch.py#L352-L364
Related PR(optional)
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
If you are adding new package following items are required:
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks