Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(obstacle_cruise_planner): add a hold stop distance feature #4720

Merged

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Aug 23, 2023

Description

This PR applies the following feature to obstacle_cruise_planner
#1434

Tests performed

planning simulator

Effects on system behavior

Nothing

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:system System design and integration. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Aug 23, 2023
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 force-pushed the feat/hold-stop-obstacle-cruise branch from 5ff7967 to 5e79b1d Compare August 23, 2023 06:20
@github-actions github-actions bot removed type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:system System design and integration. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Aug 23, 2023
@takayuki5168 takayuki5168 changed the title Feat/hold stop obstacle cruise feat(obstacle_cruise_planner): add a hold stop distance feature Aug 23, 2023
@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 23, 2023
@takayuki5168 takayuki5168 marked this pull request as ready for review August 23, 2023 06:34
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (9407021) 14.88% compared to head (5e79b1d) 14.87%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4720      +/-   ##
==========================================
- Coverage   14.88%   14.87%   -0.01%     
==========================================
  Files        1549     1549              
  Lines      107005   107028      +23     
  Branches    32808    32818      +10     
==========================================
  Hits        15925    15925              
- Misses      73683    73701      +18     
- Partials    17397    17402       +5     
Flag Coverage Δ *Carryforward flag
differential 8.40% <0.00%> (?)
total 14.88% <ø> (+<0.01%) ⬆️ Carriedforward from 9407021

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...include/obstacle_cruise_planner/common_structs.hpp 8.69% <0.00%> (-0.83%) ⬇️
...lude/obstacle_cruise_planner/planner_interface.hpp 13.51% <ø> (ø)
.../obstacle_cruise_planner/src/planner_interface.cpp 7.44% <0.00%> (-0.38%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@takayuki5168 takayuki5168 merged commit cf42588 into autowarefoundation:main Aug 23, 2023
@takayuki5168 takayuki5168 deleted the feat/hold-stop-obstacle-cruise branch August 23, 2023 23:21
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request Aug 23, 2023
…warefoundation#4720)

* feat(obstacle_cruise_planner): add a hold stop distance feature

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* add param

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Aug 24, 2023
…warefoundation#4720)

* feat(obstacle_cruise_planner): add a hold stop distance feature

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* add param

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants