Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(out_of_lane): ignore predicted paths of dynamic objects in irrelevent lanelets #4473

Conversation

maxime-clem
Copy link
Contributor

Description

This PR improves the out_of_lane module to avoid triggering unwanted stops.
When using the predicted paths of dynamic objects, we now make sure that the object is on a lanelet that can reach the out of lane overlap (without lane changes), otherwise it is ignored.

Before After
image image

Tests performed

Evaluation (TIER IV internal link): https://evaluation.tier4.jp/evaluation/reports/b250dbce-1644-51f3-9fe0-98b11d53b876?project_id=x2_dev

Effects on system behavior

Some unwanted slowdown or stop caused by the out_of_lane module should no longer happen.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem maxime-clem added component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Jul 31, 2023
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.03% 🎉

Comparison is base (37c80ad) 14.88% compared to head (07bb7f8) 14.92%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4473      +/-   ##
==========================================
+ Coverage   14.88%   14.92%   +0.03%     
==========================================
  Files        1519     1520       +1     
  Lines      104953   104647     -306     
  Branches    31977    31834     -143     
==========================================
- Hits        15626    15616      -10     
+ Misses      72260    71987     -273     
+ Partials    17067    17044      -23     
Flag Coverage Δ *Carryforward flag
differential 24.11% <0.00%> (?)
total 14.92% <ø> (+0.03%) ⬆️ Carriedforward from 34e3bc8

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...vior_velocity_out_of_lane_module/src/decisions.cpp 1.09% <0.00%> (-0.06%) ⬇️

... and 33 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@takayuki5168 takayuki5168 self-assigned this Aug 1, 2023
@takayuki5168
Copy link
Contributor

@maxime-clem It seems the PR is work-in-progress. Let me know if the PR is ready to review.

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem maxime-clem merged commit 24870d9 into autowarefoundation:main Aug 3, 2023
@maxime-clem maxime-clem deleted the feat/out_of_lane/ignore_crossing_predicted_paths branch August 3, 2023 07:36
LeoDriveProject pushed a commit to leo-drive/autoware.universe.golf that referenced this pull request Aug 16, 2023
…ets (autowarefoundation#4473)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Aug 22, 2023
…ets (autowarefoundation#4473)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
maxime-clem added a commit to maxime-clem/autoware.universe that referenced this pull request Aug 28, 2023
…ets (autowarefoundation#4473)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
t4-x2 pushed a commit to tier4/autoware.universe that referenced this pull request Aug 29, 2023
…ets (autowarefoundation#4473)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
maxime-clem added a commit to tier4/autoware.universe that referenced this pull request Sep 4, 2023
…ets (autowarefoundation#4473)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
maxime-clem added a commit to tier4/autoware.universe that referenced this pull request Sep 4, 2023
…ets (autowarefoundation#4473)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants