-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(out_of_lane): ignore predicted paths of dynamic objects in irrelevent lanelets #4473
feat(out_of_lane): ignore predicted paths of dynamic objects in irrelevent lanelets #4473
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4473 +/- ##
==========================================
+ Coverage 14.88% 14.92% +0.03%
==========================================
Files 1519 1520 +1
Lines 104953 104647 -306
Branches 31977 31834 -143
==========================================
- Hits 15626 15616 -10
+ Misses 72260 71987 -273
+ Partials 17067 17044 -23
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
@maxime-clem It seems the PR is work-in-progress. Let me know if the PR is ready to review. |
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
…ets (autowarefoundation#4473) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
…ets (autowarefoundation#4473) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
…ets (autowarefoundation#4473) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
…ets (autowarefoundation#4473) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
…ets (autowarefoundation#4473) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
…ets (autowarefoundation#4473) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Description
This PR improves the
out_of_lane
module to avoid triggering unwanted stops.When using the predicted paths of dynamic objects, we now make sure that the object is on a lanelet that can reach the out of lane overlap (without lane changes), otherwise it is ignored.
Tests performed
Evaluation (TIER IV internal link): https://evaluation.tier4.jp/evaluation/reports/b250dbce-1644-51f3-9fe0-98b11d53b876?project_id=x2_dev
Effects on system behavior
Some unwanted slowdown or stop caused by the
out_of_lane
module should no longer happen.Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.