Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(intersection): disable pass judge decision while peeking #4468

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Jul 31, 2023

Description

If intersection_occlusion stop line is ahead of the pass_judge_line, ego vehicle might possibly skip collision checking.

Related links

https://tier4.atlassian.net/browse/RT1-2844

Tests performed

Psim and experiment

Notes for reviewers

Interface changes

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@soblin soblin marked this pull request as ready for review July 31, 2023 07:16
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jul 31, 2023
@soblin soblin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 31, 2023
@soblin soblin enabled auto-merge (squash) July 31, 2023 10:41
@soblin soblin changed the title disable pass judge decision while peeking feat(intersection): disable pass judge decision while peeking Jul 31, 2023
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.05% ⚠️

Comparison is base (8a82fa9) 14.91% compared to head (5ce1664) 14.87%.
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4468      +/-   ##
==========================================
- Coverage   14.91%   14.87%   -0.05%     
==========================================
  Files        1517     1517              
  Lines      104695   105030     +335     
  Branches    31880    32126     +246     
==========================================
  Hits        15619    15619              
- Misses      72024    72334     +310     
- Partials    17052    17077      +25     
Flag Coverage Δ *Carryforward flag
differential 7.27% <0.00%> (?)
total 14.91% <ø> (+<0.01%) ⬆️ Carriedforward from 8a82fa9

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...ity_intersection_module/src/scene_intersection.cpp 0.00% <0.00%> (ø)
...ity_intersection_module/src/scene_intersection.hpp 0.00% <ø> (ø)
...behavior_velocity_intersection_module/src/util.cpp 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soblin soblin merged commit c2564ae into autowarefoundation:main Aug 1, 2023
@soblin soblin deleted the fix/intersection/disable-pass-judge-go-while-peeking branch August 1, 2023 04:06
felixf4xu pushed a commit to felixf4xu/autoware.universe that referenced this pull request Aug 2, 2023
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Felix F Xu <felixfxu@gmail.com>
soblin added a commit to tier4/autoware.universe that referenced this pull request Aug 8, 2023
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
1222-takeshi pushed a commit to tier4/autoware.universe that referenced this pull request Aug 14, 2023
) (#717)

disable pass judge decision while peeking (autowarefoundation#4468)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants