Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dynamic_avoidance): revert debug marker's color #4450

Merged

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Jul 28, 2023

Description

Revert #3926
The color of dynamic avoidance has changed from purple to pink for better visibility on Rviz.
The pink color is not used by any other modules now.

Tests performed

planning simualtor

Effects on system behavior

Nothing

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 28, 2023
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jul 28, 2023
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (7a76469) 14.91% compared to head (4a44503) 14.91%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4450   +/-   ##
=======================================
  Coverage   14.91%   14.91%           
=======================================
  Files        1517     1517           
  Lines      104684   104684           
  Branches    31869    31869           
=======================================
  Hits        15613    15613           
  Misses      72034    72034           
  Partials    17037    17037           
Flag Coverage Δ *Carryforward flag
differential 13.26% <0.00%> (?)
total 14.91% <ø> (+<0.01%) ⬆️ Carriedforward from 7a76469

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...ule/dynamic_avoidance/dynamic_avoidance_module.cpp 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@takayuki5168
Copy link
Contributor Author

@kosuke55 Could you approve the PR.

@takayuki5168 takayuki5168 merged commit da69d7e into autowarefoundation:main Jul 31, 2023
@takayuki5168 takayuki5168 deleted the chore/dynamic-avoidance-color branch July 31, 2023 00:38
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Aug 1, 2023
…tion#4450)

Revert "chore(dynamic_avoidance): change debug marker's color (autowarefoundation#3926)"

This reverts commit fc08b4f.
felixf4xu pushed a commit to felixf4xu/autoware.universe that referenced this pull request Aug 2, 2023
…tion#4450)

Revert "chore(dynamic_avoidance): change debug marker's color (autowarefoundation#3926)"

This reverts commit fc08b4f.

Signed-off-by: Felix F Xu <felixfxu@gmail.com>
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request Aug 9, 2023
…tion#4450)

Revert "chore(dynamic_avoidance): change debug marker's color (autowarefoundation#3926)"

This reverts commit fc08b4f.
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request Nov 26, 2023
…tion#4450)

Revert "chore(dynamic_avoidance): change debug marker's color (autowarefoundation#3926)"

This reverts commit fc08b4f.
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request Dec 25, 2023
…tion#4450)

Revert "chore(dynamic_avoidance): change debug marker's color (autowarefoundation#3926)"

This reverts commit fc08b4f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants