-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(dynamic_avoidance): revert debug marker's color #4450
Merged
takayuki5168
merged 1 commit into
autowarefoundation:main
from
tier4:chore/dynamic-avoidance-color
Jul 31, 2023
Merged
chore(dynamic_avoidance): revert debug marker's color #4450
takayuki5168
merged 1 commit into
autowarefoundation:main
from
tier4:chore/dynamic-avoidance-color
Jul 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…refoundation#3926)" This reverts commit fc08b4f.
takayuki5168
added
the
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Jul 28, 2023
github-actions
bot
added
the
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
label
Jul 28, 2023
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #4450 +/- ##
=======================================
Coverage 14.91% 14.91%
=======================================
Files 1517 1517
Lines 104684 104684
Branches 31869 31869
=======================================
Hits 15613 15613
Misses 72034 72034
Partials 17037 17037
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
takayuki5168
requested review from
rej55,
kosuke55,
kyoichi-sugahara,
satoshi-ota,
shmpwk,
taikitanaka3,
TakaHoribe,
tkimura4,
purewater0901 and
zulfaqar-azmi-t4
as code owners
July 31, 2023 00:36
@kosuke55 Could you approve the PR. |
kosuke55
approved these changes
Jul 31, 2023
kminoda
pushed a commit
to kminoda/autoware.universe
that referenced
this pull request
Aug 1, 2023
…tion#4450) Revert "chore(dynamic_avoidance): change debug marker's color (autowarefoundation#3926)" This reverts commit fc08b4f.
felixf4xu
pushed a commit
to felixf4xu/autoware.universe
that referenced
this pull request
Aug 2, 2023
…tion#4450) Revert "chore(dynamic_avoidance): change debug marker's color (autowarefoundation#3926)" This reverts commit fc08b4f. Signed-off-by: Felix F Xu <felixfxu@gmail.com>
takayuki5168
added a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 9, 2023
…tion#4450) Revert "chore(dynamic_avoidance): change debug marker's color (autowarefoundation#3926)" This reverts commit fc08b4f.
takayuki5168
added a commit
to tier4/autoware.universe
that referenced
this pull request
Nov 26, 2023
…tion#4450) Revert "chore(dynamic_avoidance): change debug marker's color (autowarefoundation#3926)" This reverts commit fc08b4f.
takayuki5168
added a commit
to tier4/autoware.universe
that referenced
this pull request
Dec 25, 2023
…tion#4450) Revert "chore(dynamic_avoidance): change debug marker's color (autowarefoundation#3926)" This reverts commit fc08b4f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Revert #3926
The color of dynamic avoidance has changed from purple to pink for better visibility on Rviz.
The pink color is not used by any other modules now.
Tests performed
planning simualtor
Effects on system behavior
Nothing
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.